Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: content/browser/browser_child_process_host.cc

Issue 8356042: Switch ChildProcess.* enum histograms from COUNTS to ENUMERATION. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/child_process_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_child_process_host.cc
diff --git a/content/browser/browser_child_process_host.cc b/content/browser/browser_child_process_host.cc
index 7b79495e8601e62f6f3206961807cae4fd82b462..af10c45d74c95237b69651663d9ec97ec30a256d 100644
--- a/content/browser/browser_child_process_host.cc
+++ b/content/browser/browser_child_process_host.cc
@@ -149,9 +149,11 @@ void BrowserChildProcessHost::OnChildDisconnected() {
OnProcessCrashed(exit_code);
// Report that this child process crashed.
Notify(content::NOTIFICATION_CHILD_PROCESS_CRASHED);
- UMA_HISTOGRAM_COUNTS("ChildProcess.Crashes", this->type());
+ UMA_HISTOGRAM_ENUMERATION("ChildProcess.Crashed",
+ this->type(), MAX_PROCESS);
if (disconnect_was_alive_) {
- UMA_HISTOGRAM_COUNTS("ChildProcess.CrashesWasAlive", this->type());
+ UMA_HISTOGRAM_ENUMERATION("ChildProcess.CrashedWasAlive",
+ this->type(), MAX_PROCESS);
}
break;
}
@@ -159,9 +161,11 @@ void BrowserChildProcessHost::OnChildDisconnected() {
OnProcessWasKilled(exit_code);
// Report that this child process was killed.
Notify(content::NOTIFICATION_CHILD_PROCESS_WAS_KILLED);
- UMA_HISTOGRAM_COUNTS("ChildProcess.Kills", this->type());
+ UMA_HISTOGRAM_ENUMERATION("ChildProcess.Killed",
+ this->type(), MAX_PROCESS);
if (disconnect_was_alive_) {
- UMA_HISTOGRAM_COUNTS("ChildProcess.KillsWasAlive", this->type());
+ UMA_HISTOGRAM_ENUMERATION("ChildProcess.KilledWasAlive",
+ this->type(), MAX_PROCESS);
}
break;
}
« no previous file with comments | « no previous file | content/common/child_process_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698