Issue 8352045: Fix missing write barrier in deserialization. Issue 1783.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8352045: Fix missing write barrier in deserialization. Issue 1783. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix missing write barrier in deserialization. Issue 1783. Committed: http://code.google.com/p/v8/source/detail?r=9744

Patch Set 4 : '' #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -6 lines)			Patch
	M	src/heap.h	View	1 2 3	5 chunks	+11 lines, -1 line	1 comment	Download
	M	src/serialize.cc	View	1 2 3	4 chunks	+28 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

http://codereview.chromium.org/8352045/diff/6006/src/heap-inl.h File src/heap-inl.h (right): http://codereview.chromium.org/8352045/diff/6006/src/heap-inl.h#newcode279 src/heap-inl.h:279: bool Heap::InMovingPage(Object* object) { I think we really don't ...

9 years, 2 months ago (2011-10-21 11:34:35 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-10-21 13:39:42 UTC) #3

lgtm

http://codereview.chromium.org/8352045/diff/7003/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/8352045/diff/7003/src/heap.h#newcode1487
src/heap.h:1487: !HEAP->InNewSpace(value));                                     
    \
accessing heap from the heap with a HEAP accessor.

Expand Messages | Collapse Messages

Issue 8352045: Fix missing write barrier in deserialization. Issue 1783. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages