Fix missing write barrier in deserialization. Issue 1783.

src/heap-inl.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 258 matching lines @@
 
 bool Heap::InNewSpace(Object* object) {
   bool result = new_space_.Contains(object);
   ASSERT(!result ||                  // Either not in new space
          gc_state_ != NOT_IN_GC ||   // ... or in the middle of GC
          InToSpace(object));         // ... or in to-space (where we allocate).
   return result;
 }
 
 
+bool Heap::InMovingPage(Object* object) {

[Vyacheslav Egorov (Chromium), 2011/10/21 11:34:35]

I think we really don't need to invoke any incremental write-barriers when
deserializing a context as all objects are white.

[for safety we can enter nomarkingscope when we start deserialization]

+  if (object->IsSmi()) return false;
+  HeapObject* heap_object = HeapObject::cast(object);
+  if (InNewSpace(heap_object)) return true;
+  Address address = heap_object->address();
+  if (lo_space()->Contains(heap_object)) return false;
+  if (old_pointer_space()->FirstPage()->Contains(address)) return false;
+  if (old_data_space()->FirstPage()->Contains(address)) return false;
+  if (map_space()->FirstPage()->Contains(address)) return false;
+  return true;
+}
+
+
 bool Heap::InNewSpace(Address addr) {
   return new_space_.Contains(addr);
 }
 
 
 bool Heap::InFromSpace(Object* object) {
   return new_space_.FromSpaceContains(object);
 }
 
 
@@ skipping 385 matching lines @@
 
 
 Heap* _inline_get_heap_() {
   return HEAP;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_INL_H_