Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/filters/ffmpeg_demuxer.h

Issue 8352019: Change Read size to a size_t for clarity (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.cc » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.h
===================================================================
--- media/filters/ffmpeg_demuxer.h (revision 102015)
+++ media/filters/ffmpeg_demuxer.h (working copy)
@@ -147,7 +147,7 @@
virtual base::TimeDelta GetStartTime() const OVERRIDE;
// FFmpegProtocol implementation.
Ami GONE FROM CHROMIUM 2011/10/19 21:14:58 s/FFmpegProtocol/FFmpegURLProtocol/
Cris Neckar 2011/10/19 22:25:41 Done.
- virtual int Read(int size, uint8* data) OVERRIDE;
+ virtual int Read(size_t size, uint8* data) OVERRIDE;
Ami GONE FROM CHROMIUM 2011/10/19 21:14:58 what about the return value?
Cris Neckar 2011/10/19 22:25:41 Done.
virtual bool GetPosition(int64* position_out) OVERRIDE;
virtual bool SetPosition(int64 position) OVERRIDE;
virtual bool GetSize(int64* size_out) OVERRIDE;
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.cc » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698