Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: media/filters/ffmpeg_demuxer.h

Issue 8352019: Change Read size to a size_t for clarity (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.cc » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Implements the Demuxer interface using FFmpeg's libavformat. At this time 5 // Implements the Demuxer interface using FFmpeg's libavformat. At this time
6 // will support demuxing any audio/video format thrown at it. The streams 6 // will support demuxing any audio/video format thrown at it. The streams
7 // output mime types audio/x-ffmpeg and video/x-ffmpeg and include an integer 7 // output mime types audio/x-ffmpeg and video/x-ffmpeg and include an integer
8 // key FFmpegCodecID which contains the CodecID enumeration value. The CodecIDs 8 // key FFmpegCodecID which contains the CodecID enumeration value. The CodecIDs
9 // can be used to create and initialize the corresponding FFmpeg decoder. 9 // can be used to create and initialize the corresponding FFmpeg decoder.
10 // 10 //
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 virtual void Stop(FilterCallback* callback) OVERRIDE; 139 virtual void Stop(FilterCallback* callback) OVERRIDE;
140 virtual void Seek(base::TimeDelta time, const FilterStatusCB& cb) OVERRIDE; 140 virtual void Seek(base::TimeDelta time, const FilterStatusCB& cb) OVERRIDE;
141 virtual void OnAudioRendererDisabled() OVERRIDE; 141 virtual void OnAudioRendererDisabled() OVERRIDE;
142 virtual void set_host(FilterHost* filter_host) OVERRIDE; 142 virtual void set_host(FilterHost* filter_host) OVERRIDE;
143 virtual void SetPlaybackRate(float playback_rate) OVERRIDE; 143 virtual void SetPlaybackRate(float playback_rate) OVERRIDE;
144 virtual scoped_refptr<DemuxerStream> GetStream( 144 virtual scoped_refptr<DemuxerStream> GetStream(
145 DemuxerStream::Type type) OVERRIDE; 145 DemuxerStream::Type type) OVERRIDE;
146 virtual void SetPreload(Preload preload) OVERRIDE; 146 virtual void SetPreload(Preload preload) OVERRIDE;
147 virtual base::TimeDelta GetStartTime() const OVERRIDE; 147 virtual base::TimeDelta GetStartTime() const OVERRIDE;
148 148
149 // FFmpegProtocol implementation. 149 // FFmpegProtocol implementation.
Ami GONE FROM CHROMIUM 2011/10/19 21:14:58 s/FFmpegProtocol/FFmpegURLProtocol/
Cris Neckar 2011/10/19 22:25:41 Done.
150 virtual int Read(int size, uint8* data) OVERRIDE; 150 virtual int Read(size_t size, uint8* data) OVERRIDE;
Ami GONE FROM CHROMIUM 2011/10/19 21:14:58 what about the return value?
Cris Neckar 2011/10/19 22:25:41 Done.
151 virtual bool GetPosition(int64* position_out) OVERRIDE; 151 virtual bool GetPosition(int64* position_out) OVERRIDE;
152 virtual bool SetPosition(int64 position) OVERRIDE; 152 virtual bool SetPosition(int64 position) OVERRIDE;
153 virtual bool GetSize(int64* size_out) OVERRIDE; 153 virtual bool GetSize(int64* size_out) OVERRIDE;
154 virtual bool IsStreaming() OVERRIDE; 154 virtual bool IsStreaming() OVERRIDE;
155 155
156 // Provide access to FFmpegDemuxerStream. 156 // Provide access to FFmpegDemuxerStream.
157 MessageLoop* message_loop(); 157 MessageLoop* message_loop();
158 158
159 // For testing purposes. 159 // For testing purposes.
160 void disable_first_seek_hack_for_testing() { first_seek_hack_ = false; } 160 void disable_first_seek_hack_for_testing() { first_seek_hack_ = false; }
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 // starting clock value to match the timestamps in the media file. Default 256 // starting clock value to match the timestamps in the media file. Default
257 // is 0. 257 // is 0.
258 base::TimeDelta start_time_; 258 base::TimeDelta start_time_;
259 259
260 DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxer); 260 DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxer);
261 }; 261 };
262 262
263 } // namespace media 263 } // namespace media
264 264
265 #endif // MEDIA_FILTERS_FFMPEG_DEMUXER_H_ 265 #endif // MEDIA_FILTERS_FFMPEG_DEMUXER_H_
OLDNEW
« no previous file with comments | « no previous file | media/filters/ffmpeg_demuxer.cc » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698