PPAPI NaCl Proxy: optimize PPB_Fullscreen::IsFullscreen.

PPAPI NaCl Proxy: optimize PPB_Fullscreen::IsFullscreen.
Given the intended usage of the Fullscreen API, IsFullscreen is likely to be
called by the user within each DidChangeView to handle fullscreen mode changes.
Use DidChangeView RPC to keep track of the fullscreen state to avoid extra RPCs.
Implement IsFullscreen locally to just query that state.

BUG=101433
TEST=scons run_ppapi_ppb_fullscreen_browser_test
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107184

[bbudge, 2011-10-25 17:11:46]

One comment about setters.

http://codereview.chromium.org/8351023/diff/1/ppapi/native_client/src/shared/...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_instance_data.h (right):

http://codereview.chromium.org/8351023/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/plugin_instance_data.h:35: void
set_is_fullscreen(bool value) { is_fullscreen_ = value; }
It looks like this (and set_position) should only be called inside methods of
this class. If that's the case, these should be private, or even removed, and
instead just set the fields.

[polina, 2011-10-25 18:52:19]

http://codereview.chromium.org/8351023/diff/1/ppapi/native_client/src/shared/...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_instance_data.h (right):

http://codereview.chromium.org/8351023/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/plugin_instance_data.h:35: void
set_is_fullscreen(bool value) { is_fullscreen_ = value; }
On 2011/10/25 17:11:46, bbudge1 wrote:
> It looks like this (and set_position) should only be called inside methods of
> this class. If that's the case, these should be private, or even removed, and
> instead just set the fields.

Done.

[bbudge, 2011-10-25 19:09:31]

LGTM. Nice optimization.

[polina, 2011-10-25 20:06:08]

On 2011/10/25 19:09:31, bbudge1 wrote:
> LGTM. Nice optimization.

Committed revision 107184.