PPAPI NaCl Proxy: optimize PPB_Fullscreen::IsFullscreen.

ppapi/native_client/src/shared/ppapi_proxy/plugin_instance_data.h

 /*
  * Copyright 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_SHARED_PPAPI_PROXY_PLUGIN_INSTANCE_DATA_H_
 #define NATIVE_CLIENT_SRC_SHARED_PPAPI_PROXY_PLUGIN_INSTANCE_DATA_H_
 
 #include "native_client/src/include/nacl_macros.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_rect.h"
 
 namespace ppapi_proxy {
 
 // Per-instance data on the plugin side.
 class PluginInstanceData {
  public:
   static PluginInstanceData* FromPP(PP_Instance id);
   static void DidCreate(PP_Instance id);
   static void DidDestroy(PP_Instance id);
-  static void DidChangeView(PP_Instance id, PP_Rect position, PP_Rect clip);
+  static void DidChangeView(PP_Instance id, PP_Rect position, PP_Rect clip,
+                            bool is_fullscreen);
+  static bool IsFullscreen(PP_Instance id);
 
   PluginInstanceData(PP_Instance id)
     : id_(id), position_(PP_MakeRectFromXYWH(0, 0, 0, 0)) {
   }
   ~PluginInstanceData() {}
 
   PP_Instance id() { return id_; }
   PP_Rect position() { return position_; }
   void set_position(PP_Rect position) { position_ = position; }
+  bool is_fullscreen() { return is_fullscreen_; }
+  void set_is_fullscreen(bool value) { is_fullscreen_ = value; }

[bbudge, 2011/10/25 17:11:46]

It looks like this (and set_position) should only be called inside methods of
this class. If that's the case, these should be private, or even removed, and
instead just set the fields.

[polina, 2011/10/25 18:52:19]

Done.

 
  private:
   NACL_DISALLOW_COPY_AND_ASSIGN(PluginInstanceData);
 
   PP_Instance id_;
   PP_Rect position_;
+  bool is_fullscreen_;
 };
 
 }  // namespace ppapi_proxy
 
 #endif  // NATIVE_CLIENT_SRC_SHARED_PPAPI_PROXY_PLUGIN_INSTANCE_DATA_H_