Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 8349011: Improve error message when the upstream branch is wrong. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Improve error message when the upstream branch is wrong. Otherwise, I get a stack trace, which is annoying. Here's an example: $ git cl upload Current branch help_text is up to date. Failed to diff against upstream branch refs/heads/foo! This branch probably doesn't exist anymore. To reset the tracking branch, please run git branch --set-upstream help_text trunk replacing trunk with origin/master or the relevant branch R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M git_cl.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-18 20:49:10 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-10-18 21:03:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8349011/1
9 years, 2 months ago (2011-10-18 23:58:34 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-19 00:04:37 UTC) #4
Change committed as 106175

Powered by Google App Engine
This is Rietveld 408576698