Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: git_cl.py

Issue 8349011: Improve error message when the upstream branch is wrong. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 58cbd680cd7f7cf990b38a7c31c61390e422e631..9566118c596a8f48457ab215c7bbfa0386110c2f 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -495,7 +495,16 @@ or verify this branch is set up to track another (via the --track argument to
# We use the sha1 of HEAD as a name of this change.
name = RunCommand(['git', 'rev-parse', 'HEAD']).strip()
# Need to pass a relative path for msysgit.
- files = scm.GIT.CaptureStatus([root], upstream_branch)
+ try:
+ files = scm.GIT.CaptureStatus([root], upstream_branch)
+ except subprocess2.CalledProcessError:
+ DieWithError(
+ ('\nFailed to diff against upstream branch %s!\n\n'
+ 'This branch probably doesn\'t exist anymore. To reset the\n'
+ 'tracking branch, please run\n'
+ ' git branch --set-upstream %s trunk\n'
+ 'replacing trunk with origin/master or the relevant branch') %
+ (upstream_branch, self.GetBranch()))
issue = ConvertToInteger(self.GetIssue())
patchset = ConvertToInteger(self.GetPatchset())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698