Issue 8349009: Support playback & seeking in media files over 2G.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8349009: Support playback & seeking in media files over 2G. (Closed)

Created:
9 years, 2 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 2 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, darin (slow to review), commit-bot: I haz the power

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support playback & seeking in media files over 2G. BUG=95805 TEST=unittests of touched files pass, manually tested w/ sonyh2.webm which is >5G (internal only), and trybots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106183

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -23 lines)			Patch
M	webkit/glue/media/buffered_resource_loader.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/multipart_response_delegate.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/multipart_response_delegate.cc	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	webkit/glue/multipart_response_delegate_unittest.cc	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_impl.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

darin: Please review for webkit/OWNERS acolwell: please review everything

9 years, 2 months ago (2011-10-18 20:35:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/8349009/1

9 years, 2 months ago (2011-10-18 22:17:53 UTC) #5

Change committed as 106183

Expand Messages | Collapse Messages