Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webkit/glue/multipart_response_delegate_unittest.cc

Issue 8349009: Support playback & seeking in media files over 2G. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/multipart_response_delegate.cc ('k') | webkit/plugins/npapi/webplugin_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/multipart_response_delegate_unittest.cc
diff --git a/webkit/glue/multipart_response_delegate_unittest.cc b/webkit/glue/multipart_response_delegate_unittest.cc
index bebb9f072046e004e3b8137131f42e8e138cc508..01f68e44c54d19b0a84c11fe642558f6dd4252f2 100644
--- a/webkit/glue/multipart_response_delegate_unittest.cc
+++ b/webkit/glue/multipart_response_delegate_unittest.cc
@@ -566,12 +566,14 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) {
WebURLResponse response1;
response1.initialize();
response1.setMIMEType("application/pdf");
- response1.setHTTPHeaderField("Content-Length", "200");
- response1.setHTTPHeaderField("Content-Range", "bytes 1000-1050/5000");
+ response1.setHTTPHeaderField("Content-Length", "200"); // Ignored!
+ // Use intentionally >32bit values to check they are handled correctly.
+ response1.setHTTPHeaderField("Content-Range",
+ "bytes 5000000000-5000000050/6000000000");
- int content_range_lower_bound = 0;
- int content_range_upper_bound = 0;
- int content_range_instance_size = 0;
+ int64 content_range_lower_bound = 0;
+ int64 content_range_upper_bound = 0;
+ int64 content_range_instance_size = 0;
bool result = MultipartResponseDelegate::ReadContentRanges(
response1, &content_range_lower_bound,
@@ -579,8 +581,9 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) {
&content_range_instance_size);
EXPECT_EQ(result, true);
- EXPECT_EQ(content_range_lower_bound, 1000);
- EXPECT_EQ(content_range_upper_bound, 1050);
+ EXPECT_EQ(content_range_lower_bound, 5e9);
+ EXPECT_EQ(content_range_upper_bound, 5e9+50);
+ EXPECT_EQ(content_range_instance_size, 6e9);
WebURLResponse response2;
response2.initialize();
« no previous file with comments | « webkit/glue/multipart_response_delegate.cc ('k') | webkit/plugins/npapi/webplugin_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698