Issue 8349007: Revert 106069 - Fix for Memory Leak 72698_b

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8349007: Revert 106069 - Fix for Memory Leak 72698_b (Closed)

Created:
9 years, 2 months ago by Lei Zhang

Modified:
9 years, 2 months ago

Reviewers:
Parag Radke

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 106069 - Fix for Memory Leak 72698_b BUG=72698 TEST= Review URL: http://codereview.chromium.org/8330018 TBR=nrqv63@motorola.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106112

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	AUTHORS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl_io_data.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl_io_data.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Leak shows up again with r106069: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20UI%20%28valgrind%29%284%29/builds/4653/steps/memory%20test%3A%20ui/logs/40D86676AFC4E24B

9 years, 2 months ago (2011-10-18 20:19:58 UTC) #2

Parag Radke

9 years, 2 months ago (2011-10-20 06:38:12 UTC) #3

Actually it was wrong to remove the whole suppression for this fix. The same
suppression can be observed in incognito mode. I uploaded the new fix which
takes care of both case.
Review url : http://codereview.chromium.org/8342068

On 2011/10/18 20:19:58, Lei Zhang wrote:
> Leak shows up again with r106069:
> 
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%2520OS%2520...

Expand Messages | Collapse Messages