Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 8342068: Fix for memory leak 72698 (Closed)

Created:
9 years, 2 months ago by Parag Radke
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix for memory leak 72698_b in both normal and incognito mode.Actually it was wrong to remove the whole suppression for this fix. The same suppression can be observed in incognito mode. BUG=72698 TEST= open google.com in 1. normal mode. 2. Incognito mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106756

Patch Set 1 #

Patch Set 2 : Removing AUTHOR file to resolve the conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Parag Radke
Please review this fix.
9 years, 2 months ago (2011-10-20 06:40:07 UTC) #1
willchan no longer on Chromium
lgtm
9 years, 2 months ago (2011-10-20 14:30:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nrqv63@motorola.com/8342068/1
9 years, 2 months ago (2011-10-20 14:30:13 UTC) #3
commit-bot: I haz the power
Can't apply patch for file AUTHORS. While running patch -p1 --forward --force; patching file AUTHORS ...
9 years, 2 months ago (2011-10-20 14:30:14 UTC) #4
Parag Radke
On 2011/10/20 14:30:14, I haz the power (commit-bot) wrote: > Can't apply patch for file ...
9 years, 2 months ago (2011-10-21 10:55:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nrqv63@motorola.com/8342068/4001
9 years, 2 months ago (2011-10-21 18:04:31 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-21 19:20:39 UTC) #7
Change committed as 106756

Powered by Google App Engine
This is Rietveld 408576698