Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: courgette/image_info_unittest.cc

Issue 8344037: Start refactoring to reduce executable type knowledge. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix comment. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/image_info.cc ('k') | courgette/versioning_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/image_info_unittest.cc
diff --git a/courgette/image_info_unittest.cc b/courgette/image_info_unittest.cc
index 7c08473c69d2a01869ce76b6354b075d45a03cc9..e0cac7d81fdd95cb1dc64e6b6298381672f54969 100644
--- a/courgette/image_info_unittest.cc
+++ b/courgette/image_info_unittest.cc
@@ -59,13 +59,14 @@ void ImageInfoTest::TestResourceDll() const {
scoped_ptr<courgette::PEInfo> info(new courgette::PEInfo());
info->Init(reinterpret_cast<const uint8*>(file1.c_str()), file1.length());
+ // This is expected to fail, since we don't really support them yet.
bool can_parse_header = info->ParseHeader();
- EXPECT_TRUE(can_parse_header);
+ EXPECT_FALSE(can_parse_header);
// The executable is the whole file, not 'embedded' with the file
EXPECT_EQ(file1.length(), info->length());
- EXPECT_TRUE(info->ok());
+ EXPECT_FALSE(info->ok());
EXPECT_FALSE(info->has_text_section());
EXPECT_EQ(0U, info->size_of_code());
}
« no previous file with comments | « courgette/image_info.cc ('k') | courgette/versioning_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698