Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: courgette/image_info.cc

Issue 8344037: Start refactoring to reduce executable type knowledge. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix comment. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/ensemble_create.cc ('k') | courgette/image_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/image_info.cc
diff --git a/courgette/image_info.cc b/courgette/image_info.cc
index 0c8cdf6038094106d1625c2db61f2ba60e939f09..0f2d9abdff29c1f19fa7b44d0e3a4e36383f706a 100644
--- a/courgette/image_info.cc
+++ b/courgette/image_info.cc
@@ -310,6 +310,14 @@ bool PEInfo::ParseHeader() {
file_length_ = section_end;
}
+ if (!is_32bit()) {
+ return Bad("64 bit executables are not yet supported");
+ }
+
+ if (!has_text_section()) {
+ return Bad("Resource-only executables are not yet supported");
+ }
+
failure_reason_ = NULL;
return true;
}
« no previous file with comments | « courgette/ensemble_create.cc ('k') | courgette/image_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698