Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8344025: Add a new globals object for PPAPI tracking information. (Closed)

Created:
9 years, 2 months ago by brettw
Modified:
9 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a new globals object for PPAPI tracking information. [ Reland of 106142: http://codereview.chromium.org/8316008 ] This adds a specialization on the host and plugin side of the proxy. This replaces the ad-hoc singleton tracking done by the resource and var trackers with just being getters on this global object. Most code can use the single PpapiGlobals class. I also allow code to get the host and plugin specializations since some code needs access to some specific features of each side. In a later pass I'll move the other stuff out of TrackerBase and delete it. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106537

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -326 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_ppb_pdf_impl.cc View 1 10 chunks +12 lines, -9 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/proxy/enter_proxy.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + ppapi/proxy/plugin_globals.h View 1 1 chunk +2 lines, -1 line 0 comments Download
A + ppapi/proxy/plugin_globals.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 1 4 chunks +2 lines, -36 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 4 chunks +4 lines, -27 lines 0 comments Download
M ppapi/proxy/plugin_var_serialization_rules.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 3 chunks +9 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_core_proxy.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_file_proxy.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_var_proxy.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.cc View 1 3 chunks +21 lines, -21 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
A ppapi/shared_impl/ppapi_globals.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppapi_globals.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/shared_impl/resource_tracker_unittest.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download
M ppapi/shared_impl/scoped_pp_resource.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ppapi/shared_impl/test_globals.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/test_globals.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/shared_impl/tracker_base.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/shared_impl/url_util_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/var.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/shared_impl/video_decoder_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM ppapi/thunk/enter.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
MM webkit/plugins/ppapi/callbacks_unittest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
A + webkit/plugins/ppapi/host_globals.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/host_globals.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM webkit/plugins/ppapi/npapi_glue.cc View 1 8 chunks +9 lines, -7 lines 0 comments Download
MM webkit/plugins/ppapi/npobject_var.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/plugin_module.cc View 1 7 chunks +20 lines, -5 lines 0 comments Download
MM webkit/plugins/ppapi/plugin_object.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 8 chunks +9 lines, -6 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_audio_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/ppb_directory_reader_impl.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_flash_clipboard_impl.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_flash_file_impl.cc View 1 7 chunks +13 lines, -6 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_flash_impl.cc View 1 4 chunks +9 lines, -4 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 4 chunks +14 lines, -6 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_var_impl.cc View 1 6 chunks +12 lines, -7 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_video_capture_impl.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/quota_file_io.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/resource_helper.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/resource_tracker.h View 1 3 chunks +2 lines, -39 lines 0 comments Download
MM webkit/plugins/ppapi/resource_tracker.cc View 1 6 chunks +2 lines, -34 lines 0 comments Download
MM webkit/plugins/ppapi/resource_tracker_unittest.cc View 1 3 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
This is a reland of the previous patch. The previous one broke the shared build. ...
9 years, 2 months ago (2011-10-20 18:08:03 UTC) #1
yzshen1
9 years, 2 months ago (2011-10-20 18:18:46 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698