Add a new globals object for PPAPI tracking information.

Add a new globals object for PPAPI tracking information.

This adds a specialization on the host and plugin side of the proxy. This
replaces the ad-hoc singleton tracking done by the resource and var trackers
with just being getters on this global object.

Most code can use the single PpapiGlobals class. I also allow code to get the
host and plugin specializations since some code needs access to some specific
features of each side.

In a later pass I'll move the other stuff out of TrackerBase and delete it.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106142

[brettw, 2011-10-17 18:17:50]

Lots of files but 95% of the changes are mechanical.

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/ppb_video_capture_p...
File ppapi/proxy/ppb_video_capture_proxy.cc (right):

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/ppb_video_capture_p...
ppapi/proxy/ppb_video_capture_proxy.cc:376: if (enter.failed() ||
!ppp_video_capture_impl_)
This file I changed around more than the others since it was doing unnecessary
work looking up the resource twice. The PP_Resource should be retrieved from the
VideoCapture object rather than looked up separately, and this is guaranteed not
to fail.

[brettw, 2011-10-18 18:35:36]

It looks like David is on vacation. Yuzhu, can you look at this? It's mostly
search and replace so the review will be easier than it looks.

[yzshen1, 2011-10-18 20:09:57]

LGTM

Thanks!

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h#ne...
ppapi/proxy/plugin_globals.h:27: virtual ResourceTracker* GetResourceTracker()
OVERRIDE;
[optional]
It seems good to me to make
PluginGlobals::Get()->GetResourceTracker() directly return
PluginResourceTracker*. If the user needs ResourceTracker*, he/she could use
PpapiGlobals::Get()->GetResourceTracker().

I think static binding could be used to do this.

[brettw, 2011-10-18 20:43:54]

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h#ne...
ppapi/proxy/plugin_globals.h:27: virtual ResourceTracker* GetResourceTracker()
OVERRIDE;
On 2011/10/18 20:09:57, yzshen1 wrote:
> [optional]
> It seems good to me to make
> PluginGlobals::Get()->GetResourceTracker() directly return
> PluginResourceTracker*. If the user needs ResourceTracker*, he/she could use
> PpapiGlobals::Get()->GetResourceTracker().

This function is an implementation of the pure virtual function on the
PpapiGlobals object. So we'll need it here no matter what (I did consider
passing these into the PpapiGlobals constructor which would save the virtual
function calls, but that seemed more complicated... we can do that if it turns
out this is showing up on perf).

> I think static binding could be used to do this.

I don't think C++ does binding based on return type, so I'm not sure how this
would work. Maybe I'm missing something, though.

[yzshen1, 2011-10-18 20:53:35]

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

http://codereview.chromium.org/8316008/diff/1/ppapi/proxy/plugin_globals.h#ne...
ppapi/proxy/plugin_globals.h:27: virtual ResourceTracker* GetResourceTracker()
OVERRIDE;
[optional, not intended to block your check in.]
I am thinking about something like this: :)

class PpapiGlobals {
  PpapiGlobals(ResourceTracker* resource_tracker)
    : resource_tracker_(resource_tracker) {}
  ...
  // Not virtual
  ResourceTracker* GetResourceTracker() {
    return resource_tracker_;
  }
};

class PluginGlobals {
  PluginGlobals()
    : PpapiGlobals(&plugin_resource_tracker_) {}
  ...
  // Not virtual
  PluginResourceTracker* GetResourceTracker() {
    return &plugin_resource_tracker_;
  }
  ...
  PluginResourceTracker plugin_resource_tracker_;
};

[brettw, 2011-10-18 22:18:02]

LGTM