Don't close background pages if there is a pending response (callback).

Don't close background pages if there is a pending response (callback).

BUG=81752
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108170

[Tessa MacDuff, 2011-10-31 16:59:30]

Also includes the changes to track in-flight events.

[Aaron Boodman, 2011-10-31 17:46:08]

Nice! Does it work?

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.cc (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.cc:291:
IncrementInFlightEvents(listener->extension_id);
Out of curiosity, why does it not work to put this in ::DispatchEvent()?

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.h (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.h:93: void
IncrementInFlightEvents(const std::string& extension_id);
Looks like Increment does not need to be public.

Also, can you rename Decrement... do ::OnExtensionEventAck to be a b it more
general/abstract, and to go better with the IPC it is handling?

http://codereview.chromium.org/8343079/diff/4001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_messages.h (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/common/extensions/ext...
chrome/common/extensions/extension_messages.h:277:
IPC_MESSAGE_CONTROL1(ExtensionHostMsg_EventDispatch,
Nit: can you call this ExtensionHostMsg_ExtensionEventAck to make it more clear
what its purpose is?

http://codereview.chromium.org/8343079/diff/4001/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_dispatcher.cc:166: void
ExtensionDispatcher::OnExtensionIdle(const std::string& extension_id) {
How about "CheckIdleStatus".

[Tessa MacDuff, 2011-10-31 19:01:28]

It totally works!  I can show you today! (I'm in MV now but will be in SF this
afternoon to pack up.)

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.cc (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.cc:291:
IncrementInFlightEvents(listener->extension_id);
On 2011/10/31 17:46:08, Aaron Boodman wrote:
> Out of curiosity, why does it not work to put this in ::DispatchEvent()?

Because DispatchEvent is static and can't access in_flight_events_.

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_event_router.h (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_event_router.h:93: void
IncrementInFlightEvents(const std::string& extension_id);
On 2011/10/31 17:46:08, Aaron Boodman wrote:
> Looks like Increment does not need to be public.
> 
> Also, can you rename Decrement... do ::OnExtensionEventAck to be a b it more
> general/abstract, and to go better with the IPC it is handling?

Done.

http://codereview.chromium.org/8343079/diff/4001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_messages.h (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/common/extensions/ext...
chrome/common/extensions/extension_messages.h:277:
IPC_MESSAGE_CONTROL1(ExtensionHostMsg_EventDispatch,
On 2011/10/31 17:46:08, Aaron Boodman wrote:
> Nit: can you call this ExtensionHostMsg_ExtensionEventAck to make it more
clear
> what its purpose is?

Done.

http://codereview.chromium.org/8343079/diff/4001/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/8343079/diff/4001/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_dispatcher.cc:166: void
ExtensionDispatcher::OnExtensionIdle(const std::string& extension_id) {
On 2011/10/31 17:46:08, Aaron Boodman wrote:
> How about "CheckIdleStatus".

Done.

[Aaron Boodman, 2011-11-01 00:32:54]

lgtm

[commit-bot: I haz the power, 2011-11-01 18:40:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tessamac@chromium.org/8343079/4002

[commit-bot: I haz the power, 2011-11-01 18:41:38]

Try job failure for 8343079-4002 on linux_rel for steps "update_scripts,
update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-11-01 20:06:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tessamac@chromium.org/8343079/10001

[commit-bot: I haz the power, 2011-11-01 21:23:58]

Change committed as 108170