chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 8343079: Don't close background pages if there is a pending response (callback).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 8343079: Don't close background pages if there is a pending response (callback). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index db3e7c5b7022b44b16571dc2986c8d6a08456031..e9c044ca12f039b101e2bc876c792f170c1e3f1a 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -87,10 +87,9 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest,

bg_pg_created.Wait();

bg_pg_closed.Wait();

- // Background page is closed before it created a new tab.

- // TODO(tessamac): Implement! Close background page after callback.

+ // Background page is closed after creating a new tab.

EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id_));

- EXPECT_EQ(num_tabs_before, browser()->tab_count());

+ EXPECT_EQ(num_tabs_before + 1, browser()->tab_count());

}

IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest,