Disk Cache: Supress tsan warnings for BackendTrimInvalidEntry2

net/disk_cache/backend_unittest.cc

Index: net/disk_cache/backend_unittest.cc
===================================================================
--- net/disk_cache/backend_unittest.cc	(revision 107659)
+++ net/disk_cache/backend_unittest.cc	(working copy)
@@ -784,6 +784,7 @@
 
 // We'll be leaking memory from this test.
 void DiskCacheBackendTest::BackendTrimInvalidEntry2() {
+  ANNOTATE_IGNORE_READS_AND_WRITES_BEGIN();

[rvargas (doing something else), 2011/10/28 03:03:06]

I'm assuming that it is fine if the test asserts and doesn't reach the _end()
macro. Or do I have to make sure that doesn't happen?

[kcc2, 2011/10/28 03:15:32]

If the test asserts and then exits -- fine. 
But if you call BEGIN, don't call END and the test proceeds, a bad thing will
happen -- race detection will be disable for all further tests. 
I'd suggest to move the annotations to the place where you call
BackendTrimInvalidEntry2

[Timur Iskhodzhanov, 2011/10/28 12:14:02]

Assert indeed interrupts the test.

On 2011/10/28 03:15:32, kcc2 wrote:

   // Use the implementation directly... we need to simulate a crash.
   SetDirectMode();
   SetMask(0xf);  // 16-entry table.
@@ -829,6 +830,7 @@
   MessageLoop::current()->RunAllPending();
   FlushQueueForTest();
   EXPECT_GE(30, cache_->GetEntryCount());

[Timur Iskhodzhanov, 2011/10/28 12:14:02]

ANNOTATE_IGNORE_READS_AND_WRITES_BEGIN();
int cache_entry_count = cache_->GetEntryCount();
ANNOTATE_IGNORE_READS_AND_WRITES_END();
EXPECT_GE(30, cache_entry_count);

+  ANNOTATE_IGNORE_READS_AND_WRITES_END();
 }
 
 // We'll be leaking memory from this test.