Disk Cache: Supress tsan warnings for BackendTrimInvalidEntry2

net/disk_cache/backend_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/platform_thread.h"
@@ skipping 766 matching lines @@
 }
 
 // We'll be leaking memory from this test.
 TEST_F(DiskCacheBackendTest, NewEvictionTrimInvalidEntry) {
   SetNewEviction();
   BackendTrimInvalidEntry();
 }
 
 // We'll be leaking memory from this test.
 void DiskCacheBackendTest::BackendTrimInvalidEntry2() {
+  ANNOTATE_IGNORE_READS_AND_WRITES_BEGIN();

[rvargas (doing something else), 2011/10/28 03:03:06]

I'm assuming that it is fine if the test asserts and doesn't reach the _end()
macro. Or do I have to make sure that doesn't happen?

[kcc2, 2011/10/28 03:15:32]

If the test asserts and then exits -- fine. 
But if you call BEGIN, don't call END and the test proceeds, a bad thing will
happen -- race detection will be disable for all further tests. 
I'd suggest to move the annotations to the place where you call
BackendTrimInvalidEntry2

[Timur Iskhodzhanov, 2011/10/28 12:14:02]

Assert indeed interrupts the test.

On 2011/10/28 03:15:32, kcc2 wrote:

   // Use the implementation directly... we need to simulate a crash.
   SetDirectMode();
   SetMask(0xf);  // 16-entry table.
 
   const int kSize = 0x3000;  // 12 kB
   SetMaxSize(kSize * 40);
   InitCache();
 
   scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(kSize));
   memset(buffer->data(), 0, kSize);
@@ skipping 24 matching lines @@
   if (new_eviction_) {
     EXPECT_EQ(net::OK, DoomAllEntries());
   }
 
   entry->Close();  // Trim the cache.
   FlushQueueForTest();
 
   // We may abort the eviction before cleaning up everything.
   MessageLoop::current()->RunAllPending();
   FlushQueueForTest();
   EXPECT_GE(30, cache_->GetEntryCount());

[Timur Iskhodzhanov, 2011/10/28 12:14:02]

ANNOTATE_IGNORE_READS_AND_WRITES_BEGIN();
int cache_entry_count = cache_->GetEntryCount();
ANNOTATE_IGNORE_READS_AND_WRITES_END();
EXPECT_GE(30, cache_entry_count);

+  ANNOTATE_IGNORE_READS_AND_WRITES_END();
 }
 
 // We'll be leaking memory from this test.
 TEST_F(DiskCacheBackendTest, TrimInvalidEntry2) {
   BackendTrimInvalidEntry2();
 }
 
 // We'll be leaking memory from this test.
 TEST_F(DiskCacheBackendTest, NewEvictionTrimInvalidEntry2) {
   SetNewEviction();
@@ skipping 1636 matching lines @@
   // Ping the oldest entry.
   cache_->OnExternalCacheHit("key0");
 
   TrimForTest(false);
 
   // Make sure the older key remains.
   EXPECT_EQ(1, cache_->GetEntryCount());
   ASSERT_EQ(net::OK, OpenEntry("key0", &entry));
   entry->Close();
 }