Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 8343018: More groundwork for flat file based response storage. (Closed)

Created:
9 years, 2 months ago by michaeln
Modified:
9 years, 2 months ago
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

More groundwork for filestream based response storage. This CL touches many files, but it amounts to mindless plumbing of a group_id value. This doesn't involve any new database or fileio or task scheduling. In order to read or write a response, callers now need to provide the group_id of the corresponding manifest, so the AppCacheStorage CreateRepsonseReader() and CreateResponseWriter() methods now take this additional parameter. The current disk_cache based impl doesn't use this param for anything, but the filestream based impl will use it to keep responses for a group in a particular subdirectory. When looking up the main resource for a page load via FindResponseForMainRequest, the group_id needs to be returned so the response may later be read, the AppCacheStorage::Delegate OnMainResponseFound() method has a param for that. A bunch of callsites, tests, and mocks are updated accordingly. BUG=78359 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106755

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -143 lines) Patch
M content/common/appcache_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/appcache/appcache_host.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_interfaces.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/appcache/appcache_interfaces.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/appcache/appcache_request_handler.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_request_handler.cc View 1 2 8 chunks +18 lines, -14 lines 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 1 2 7 chunks +7 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_response.h View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_response.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_response_unittest.cc View 1 14 chunks +14 lines, -14 lines 0 comments Download
M webkit/appcache/appcache_service.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_storage.h View 1 6 chunks +11 lines, -8 lines 0 comments Download
M webkit/appcache/appcache_storage.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.h View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.cc View 1 2 3 15 chunks +27 lines, -25 lines 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 1 2 12 chunks +14 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_update_job.cc View 1 2 3 4 5 5 chunks +11 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 7 chunks +14 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 9 chunks +12 lines, -9 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.h View 1 2 3 4 chunks +9 lines, -3 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.cc View 1 2 8 chunks +16 lines, -8 lines 0 comments Download
M webkit/appcache/mock_appcache_storage_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/appcache/view_appcache_internals_job.cc View 1 2 3 4 10 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
michaeln
ptal
9 years, 2 months ago (2011-10-20 02:37:42 UTC) #1
rvargas (doing something else)
9 years, 2 months ago (2011-10-21 01:53:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698