Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: webkit/appcache/appcache_storage_impl.h

Issue 8343018: More groundwork for flat file based response storage. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_storage.cc ('k') | webkit/appcache/appcache_storage_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_storage_impl.h
===================================================================
--- webkit/appcache/appcache_storage_impl.h (revision 106339)
+++ webkit/appcache/appcache_storage_impl.h (working copy)
@@ -49,9 +49,9 @@
virtual void MarkEntryAsForeign(const GURL& entry_url, int64 cache_id);
virtual void MakeGroupObsolete(AppCacheGroup* group, Delegate* delegate);
virtual AppCacheResponseReader* CreateResponseReader(
- const GURL& manifest_url, int64 response_id);
+ const GURL& manifest_url, int64 group_id, int64 response_id);
virtual AppCacheResponseWriter* CreateResponseWriter(
- const GURL& manifest_url);
+ const GURL& manifest_url, int64 group_id);
virtual void DoomResponses(
const GURL& manifest_url, const std::vector<int64>& response_ids);
virtual void DeleteResponses(
@@ -121,7 +121,7 @@
DelegateReferenceVector* delegates,
const GURL& url, const AppCacheEntry& entry,
const GURL& fallback_url, const AppCacheEntry& fallback_entry,
- int64 cache_id, const GURL& manifest_url);
+ int64 cache_id, int64 group_id, const GURL& manifest_url);
APPCACHE_EXPORT AppCacheDiskCache* disk_cache();
@@ -160,7 +160,6 @@
// disk cache and cannot continue.
bool is_disabled_;
- // TODO(michaeln): use a disk_cache per group (manifest or group_id).
scoped_ptr<AppCacheDiskCache> disk_cache_;
// Used to short-circuit certain operations without having to schedule
« no previous file with comments | « webkit/appcache/appcache_storage.cc ('k') | webkit/appcache/appcache_storage_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698