GTK: More profiling of the rendering path.

GTK: More profiling of the rendering path.

- Cleanup TabRendererGtk::PaintIcon so select which surface we should paint and
  instead of copy/pasting the same code in each block.
- When calling any version of GtkThemeService::GetCached*, don't first get the
  pixbuf (which can lock) and then check if you have a cairo cached version of
  the pixbuf, discarding the result of locking every time except the first.

BUG=100803
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107817

[Evan Stade, 2011-10-28 20:34:25]

lgtm

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/gtk_theme...
File chrome/browser/ui/gtk/gtk_theme_service.h (right):

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/gtk_theme...
chrome/browser/ui/gtk/gtk_theme_service.h:172: typedef
GdkPixbuf*(GtkThemeService::*PixbufProvidingMethod)(int id) const;
define type close to where it's used imo

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:848:
PaintLoadingAnimation(widget, cr);
return; instead of having rest of function in else

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:850: CairoCachedSurface*
to_display = NULL;
for your consideration:

CairoCachedSurface* to_display =
    should_display_crashed_favicon ?
        theme_service_->foo :
    data_.favicon.isNull() ?
        NULL :
    data_.is_default_favicon && theme_service_->foo ?
        theme_service::GetCairoIcon(foo) :
        &data_.cairo_favicon;

even if you don't like the ternary operator as much as me you can still use this
structure with if/else without ever needing to nest if blocks.

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:853: } else {
this can be else if instead of else { if

[commit-bot: I haz the power, 2011-10-28 20:48:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8341089/4002

[Elliot Glaysher, 2011-10-28 20:48:42]

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:848:
PaintLoadingAnimation(widget, cr);
On 2011/10/28 20:34:25, Evan Stade wrote:
> return; instead of having rest of function in else

Done.

http://codereview.chromium.org/8341089/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:853: } else {
On 2011/10/28 20:34:25, Evan Stade wrote:
> this can be else if instead of else { if

Done.

[commit-bot: I haz the power, 2011-10-28 23:17:30]

Change committed as 107817