GTK: More profiling of the rendering path.

chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc

  // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/utf_string_conversions.h"
@@ skipping 827 matching lines @@
                            *title_font_,
                            title_bounds_,
                            title_bounds_,
                            title_color,
                            base::i18n::IsRTL() ? gfx::Canvas::TEXT_ALIGN_RIGHT :
                            gfx::Canvas::TEXT_ALIGN_LEFT);
 }
 
 void TabRendererGtk::PaintIcon(GtkWidget* widget, cairo_t* cr) {
   if (loading_animation_.animation_state() != ANIMATION_NONE) {
     PaintLoadingAnimation(widget, cr);

[Evan Stade, 2011/10/28 20:34:25]

return; instead of having rest of function in else

[Elliot Glaysher, 2011/10/28 20:48:42]

Done.

   } else {
+    CairoCachedSurface* to_display = NULL;

[Evan Stade, 2011/10/28 20:34:25]

for your consideration:

CairoCachedSurface* to_display =
    should_display_crashed_favicon ?
        theme_service_->foo :
    data_.favicon.isNull() ?
        NULL :
    data_.is_default_favicon && theme_service_->foo ?
        theme_service::GetCairoIcon(foo) :
        &data_.cairo_favicon;

even if you don't like the ternary operator as much as me you can still use this
structure with if/else without ever needing to nest if blocks.

     if (should_display_crashed_favicon_) {
-      theme_service_->GetSurfaceNamed(IDR_SAD_FAVICON, widget)->SetSource(
-          cr, favicon_bounds_.x(),
-          favicon_bounds_.y() + favicon_hiding_offset_);
-      cairo_paint(cr);
+      to_display = theme_service_->GetSurfaceNamed(IDR_SAD_FAVICON, widget);
     } else {

[Evan Stade, 2011/10/28 20:34:25]

this can be else if instead of else { if

[Elliot Glaysher, 2011/10/28 20:48:42]

Done.

       if (!data_.favicon.isNull()) {
         if (data_.is_default_favicon && theme_service_->UsingNativeTheme()) {
-          GdkPixbuf* favicon = GtkThemeService::GetDefaultFavicon(true);
-
-          // TODO(erg): Get GtkThemeService to hand us a
-          // CairoCachedSurface. Then we can simplify all of this.
-          gdk_cairo_set_source_pixbuf(
-              cr, favicon, favicon_bounds_.x(),
-              favicon_bounds_.y() + favicon_hiding_offset_);
-          cairo_paint(cr);
+          to_display = theme_service_->GetCairoIcon(
+              GtkThemeService::NATIVE_FAVICON, widget);
         } else if (data_.cairo_favicon.valid()) {
-          // TODO(erg): We should research whether we still need to draw app
-          // icons larger. We don't appear to be getting larger icons.
-          data_.cairo_favicon.SetSource(
-              cr,
-              favicon_bounds_.x(),
-              favicon_bounds_.y() + favicon_hiding_offset_);
-          cairo_paint(cr);
+          to_display = &data_.cairo_favicon;
         }
       }
     }
+
+    if (to_display) {
+      to_display->SetSource(cr,
+                            favicon_bounds_.x(),
+                            favicon_bounds_.y() + favicon_hiding_offset_);
+      cairo_paint(cr);
+    }
   }
 }
 
 void TabRendererGtk::PaintTabBackground(GtkWidget* widget, cairo_t* cr) {
   if (IsActive()) {
     PaintActiveTabBackground(widget, cr);
   } else {
     PaintInactiveTabBackground(widget, cr);
 
     double throb_value = GetThrobValue();
@@ skipping 223 matching lines @@
 
   close_button_width_ = rb.GetBitmapNamed(IDR_TAB_CLOSE)->width();
   close_button_height_ = rb.GetBitmapNamed(IDR_TAB_CLOSE)->height();
 
   const gfx::Font& base_font = rb.GetFont(ResourceBundle::BaseFont);
   title_font_ = new gfx::Font(base_font.GetFontName(), kFontPixelSize);
   title_font_height_ = title_font_->GetHeight();
 
   initialized_ = true;
 }