Issue 8341079: Move cloud_print_class_mac files from content/common to chrome/common/cloud_print. They don't bel...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341079: Move cloud_print_class_mac files from content/common to chrome/common/cloud_print. They don't bel... (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
abodenha

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Move cloud_print_class_mac files from content/common to chrome/common/cloud_print. They don't belong in content. TBR=abodenha Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107626

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -53 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/common/cloud_print/cloud_print_class_mac.h	View		1 chunk	+5 lines, -6 lines	0 comments	Download
A +	chrome/common/cloud_print/cloud_print_class_mac.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/service/chrome_service_application_mac.mm	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	cloud_print/virtual_driver/posix/printer_driver_util_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
D	content/common/cloud_print_class_mac.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	content/common/cloud_print_class_mac.mm	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	content/content_common.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Albert Bodenhamer

9 years, 1 month ago (2011-10-27 20:44:15 UTC) #2

On 2011/10/27 20:17:56, John Abd-El-Malek wrote:

LGTM