chrome/common/multi_process_lock_win.cc - Issue 8341052: share all the needed linux code with OpenBSD in chrome and content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/multi_process_lock_win.cc

Issue 8341052: share all the needed linux code with OpenBSD in chrome and content (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: remove unused header Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/multi_process_lock_win.cc

diff --git a/chrome/common/multi_process_lock_win.cc b/chrome/common/multi_process_lock_win.cc

index ea31da6b19c1504904e905915cce82da7ebe4921..aa24d49f07bd90f878f0aa38771f933659960188 100644

--- a/chrome/common/multi_process_lock_win.cc

+++ b/chrome/common/multi_process_lock_win.cc

@@ -24,9 +24,9 @@ class MultiProcessLockWin : public MultiProcessLock {

return true;

}

- if (name_.length() > MULTI_PROCESS_LOCK_NAME_MAX_LEN) {

+ if (name_.length() > MAX_PATH) {

Mark Mentovai 2011/10/31 15:47:40 Should this be >= to leave room for a 0-terminator

Robert Nagy 2011/11/07 19:23:13 Done.

LOG(ERROR) << "Socket name too long (" << name_.length()

- << " > " << MULTI_PROCESS_LOCK_NAME_MAX_LEN << ") - " << name_;

+ << " > " << MAX_PATH << ") - " << name_;

return false;

}

cpu_(ooo_6.6-7.5) 2011/10/31 19:26:09 I hope this change does not mean that we are going

Robert Nagy 2011/11/07 19:23:13 MAX_PATH and MULTI_PROCESS_LOCK_NAME_MAX_LEN is ju

« no previous file with comments | « chrome/common/multi_process_lock_linux.cc ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »