Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Side by Side Diff: chrome/common/multi_process_lock_win.cc

Issue 8341052: share all the needed linux code with OpenBSD in chrome and content (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove unused header Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/multi_process_lock_linux.cc ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/multi_process_lock.h" 5 #include "chrome/common/multi_process_lock.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "base/win/scoped_handle.h" 9 #include "base/win/scoped_handle.h"
10 10
11 class MultiProcessLockWin : public MultiProcessLock { 11 class MultiProcessLockWin : public MultiProcessLock {
12 public: 12 public:
13 explicit MultiProcessLockWin(const std::string& name) : name_(name) { } 13 explicit MultiProcessLockWin(const std::string& name) : name_(name) { }
14 14
15 virtual ~MultiProcessLockWin() { 15 virtual ~MultiProcessLockWin() {
16 if (event_.Get() != NULL) { 16 if (event_.Get() != NULL) {
17 Unlock(); 17 Unlock();
18 } 18 }
19 } 19 }
20 20
21 virtual bool TryLock() { 21 virtual bool TryLock() {
22 if (event_.Get() != NULL) { 22 if (event_.Get() != NULL) {
23 DLOG(ERROR) << "MultiProcessLock is already locked - " << name_; 23 DLOG(ERROR) << "MultiProcessLock is already locked - " << name_;
24 return true; 24 return true;
25 } 25 }
26 26
27 if (name_.length() > MULTI_PROCESS_LOCK_NAME_MAX_LEN) { 27 if (name_.length() > MAX_PATH) {
Mark Mentovai 2011/10/31 15:47:40 Should this be >= to leave room for a 0-terminator
Robert Nagy 2011/11/07 19:23:13 Done.
28 LOG(ERROR) << "Socket name too long (" << name_.length() 28 LOG(ERROR) << "Socket name too long (" << name_.length()
29 << " > " << MULTI_PROCESS_LOCK_NAME_MAX_LEN << ") - " << name_; 29 << " > " << MAX_PATH << ") - " << name_;
30 return false; 30 return false;
31 } 31 }
32 32
cpu_(ooo_6.6-7.5) 2011/10/31 19:26:09 I hope this change does not mean that we are going
Robert Nagy 2011/11/07 19:23:13 MAX_PATH and MULTI_PROCESS_LOCK_NAME_MAX_LEN is ju
33 string16 wname = UTF8ToUTF16(name_); 33 string16 wname = UTF8ToUTF16(name_);
34 event_.Set(CreateEvent(NULL, FALSE, FALSE, wname.c_str())); 34 event_.Set(CreateEvent(NULL, FALSE, FALSE, wname.c_str()));
35 if (event_.Get() && GetLastError() != ERROR_ALREADY_EXISTS) { 35 if (event_.Get() && GetLastError() != ERROR_ALREADY_EXISTS) {
36 return true; 36 return true;
37 } else { 37 } else {
38 event_.Set(NULL); 38 event_.Set(NULL);
39 return false; 39 return false;
40 } 40 }
41 } 41 }
42 42
43 virtual void Unlock() { 43 virtual void Unlock() {
44 if (event_.Get() == NULL) { 44 if (event_.Get() == NULL) {
45 DLOG(ERROR) << "Over-unlocked MultiProcessLock - " << name_; 45 DLOG(ERROR) << "Over-unlocked MultiProcessLock - " << name_;
46 return; 46 return;
47 } 47 }
48 event_.Set(NULL); 48 event_.Set(NULL);
49 } 49 }
50 50
51 private: 51 private:
52 std::string name_; 52 std::string name_;
53 base::win::ScopedHandle event_; 53 base::win::ScopedHandle event_;
54 DISALLOW_COPY_AND_ASSIGN(MultiProcessLockWin); 54 DISALLOW_COPY_AND_ASSIGN(MultiProcessLockWin);
55 }; 55 };
56 56
57 MultiProcessLock* MultiProcessLock::Create(const std::string &name) { 57 MultiProcessLock* MultiProcessLock::Create(const std::string &name) {
58 return new MultiProcessLockWin(name); 58 return new MultiProcessLockWin(name);
59 } 59 }
OLDNEW
« no previous file with comments | « chrome/common/multi_process_lock_linux.cc ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698