Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 8341051: Update effective-TLD data files using the latest data from Mozilla. (Closed)

Created:
9 years, 1 month ago by Pam (message me for reviews)
Modified:
9 years, 1 month ago
Reviewers:
wtc, Peter Kasting
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Update effective-TLD data files using the latest data from Mozilla. Also expand and correct the README describing how to do this update. Due to bug 96086 (also see https://bugzilla.mozilla.org/show_bug.cgi?id=687165), entries in this list that are also known to be navigable complete URLs have been removed until a more complete solution has been put in place. This data file is Mozilla's changeset 76449:9411dffc948b, from 2011-09-02 14:08 -0400. It includes changes (some commented out) from the following Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=669792 https://bugzilla.mozilla.org/show_bug.cgi?id=531758 https://bugzilla.mozilla.org/show_bug.cgi?id=665521 BUG=37436, 96086 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108298 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108453

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Removed navigable eTLDs #

Patch Set 4 : Make comment spacing consistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -48 lines) Patch
M net/base/effective_tld_names.dat View 1 2 3 4 chunks +310 lines, -22 lines 0 comments Download
M net/base/effective_tld_names.gperf View 1 2 3 20 chunks +0 lines, -21 lines 0 comments Download
M net/tools/tld_cleanup/README View 1 3 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Pam (message me for reviews)
This patchset also includes effective_tld_names.cc, but the diff is too big for Rietveld.
9 years, 1 month ago (2011-10-26 10:31:25 UTC) #1
Peter Kasting
Due to http://crbug.com/96086 / https://bugzilla.mozilla.org/show_bug.cgi?id=687165 , it's problematic to add all the DynDNS domains to ...
9 years, 1 month ago (2011-10-26 17:42:48 UTC) #2
Pam (message me for reviews)
Thanks for the heads-up. I've commented on the bug too. I'll hang onto this for ...
9 years, 1 month ago (2011-10-27 13:07:29 UTC) #3
Pam (message me for reviews)
No progress yet, so let's at least get the fix for gov.co.uk in. Please take ...
9 years, 1 month ago (2011-10-31 14:25:28 UTC) #4
Peter Kasting
LGTM
9 years, 1 month ago (2011-10-31 21:51:51 UTC) #5
Pam (message me for reviews)
Wan-Teh, please review for net/ owners. Thanks, - Pam
9 years, 1 month ago (2011-11-02 12:59:09 UTC) #6
wtc
Patch Set 4 LGTM. I assume the actual CL also includes effective_tld_names.cc (which is too ...
9 years, 1 month ago (2011-11-02 14:13:28 UTC) #7
Pam (message me for reviews)
On 2011/11/02 14:13:28, wtc wrote: > I assume the actual CL also includes effective_tld_names.cc > ...
9 years, 1 month ago (2011-11-02 14:22:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/8341051/7007
9 years, 1 month ago (2011-11-02 14:22:43 UTC) #9
wtc
pam, pkasting: I have a question about the effective-TLD list. It seems to be used ...
9 years, 1 month ago (2011-11-02 14:22:59 UTC) #10
Pam (message me for reviews)
On 2011/11/02 14:22:59, wtc wrote: > pam, pkasting: I have a question about the effective-TLD ...
9 years, 1 month ago (2011-11-02 14:27:07 UTC) #11
commit-bot: I haz the power
9 years, 1 month ago (2011-11-02 15:34:23 UTC) #12
Change committed as 108298

Powered by Google App Engine
This is Rietveld 408576698