net/tools/tld_cleanup/README - Issue 8341051: Update effective-TLD data files using the latest data from Mozilla.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/tools/tld_cleanup/README

Issue 8341051: Update effective-TLD data files using the latest data from Mozilla. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Make comment spacing consistent Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 When updating src/net/base/effective_tld_names.dat:	1 When updating src/net/base/effective_tld_names.dat:

2	2

3 1. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project)	3 1. Obtain the new effective_tld_names.dat, probably by downloading

4 2. Run it (no arguments needed), typically from src/chrome/Release or	4 http://goo.gl/Ji2bB

5 src/chrome/Debug. It will re-generate	5

	6 2. Remove whitespace from the ends of the lines.

	7

	8 3. Add the Chromium note back in.

	9

	10 4. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project)

	11

	12 5. Run it (no arguments needed), typically from src/build/Release or

	13 src/build/Debug. It will re-generate

6 src/net/base/effective_tld_names.gperf.	14 src/net/base/effective_tld_names.gperf.

7 3. Run gperf on the new effective_tld_names.gperf:	15

	16 6. Run gperf on the new effective_tld_names.gperf:

8 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \	17 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \

9 effective_tld_names.gperf > effective_tld_names.cc	18 effective_tld_names.gperf > effective_tld_names.cc

10 It will produce a new effective_tld_names.cc.	19 It will produce a new effective_tld_names.cc.

11 4. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,	20

	21 7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,

12 and effective_tld_names.cc together.	22 and effective_tld_names.cc together.

OLD	NEW

« no previous file with comments | « net/base/effective_tld_names.gperf ('k') | no next file » | no next file with comments »