Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8341010: Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace. (Closed)

Created:
9 years, 2 months ago by Mike West
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace. While fixing these samples, I've also added `content_security_policy` as a drive-by. BUG=92644 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106059

Patch Set 1 #

Total comments: 2

Patch Set 2 : Docs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -398 lines) Patch
M chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.css View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html View 1 chunk +17 lines, -121 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js View 1 5 chunks +33 lines, -35 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/enableReferrer.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/enableReferrer/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.css View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html View 1 chunk +17 lines, -121 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.js View 1 5 chunks +33 lines, -35 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/mappy.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 6 chunks +60 lines, -52 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 4 chunks +36 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Hi Bernhard! This CL adjusts the `enableReferrer` and `allowThirdPartyCookies` to use the `privacy` namespace (we ...
9 years, 2 months ago (2011-10-18 13:13:59 UTC) #1
Bernhard Bauer
LGTM w/ a nit: http://codereview.chromium.org/8341010/diff/1/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js File chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js (right): http://codereview.chromium.org/8341010/diff/1/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js#newcode78 chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js:78: $("incognito").style.display = "block"; I know ...
9 years, 2 months ago (2011-10-18 13:21:44 UTC) #2
Mike West
9 years, 2 months ago (2011-10-18 13:47:00 UTC) #3
Cool. Updated docs, will land shortly.

http://codereview.chromium.org/8341010/diff/1/chrome/common/extensions/docs/e...
File
chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js
(right):

http://codereview.chromium.org/8341010/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js:78:
$("incognito").style.display = "block";
Excellent point. Done.

Powered by Google App Engine
This is Rietveld 408576698