chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js - Issue 8341010: Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace.

Unified Diff: chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js

Issue 8341010: Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Docs. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html ('k') | chrome/common/extensions/docs/examples/api/preferences/enableReferrer.zip » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js

diff --git a/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html b/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js

similarity index 63%

copy from chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html

copy to chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js

index 11f8d11b15c397db837fcfa1e72fe2b67c45b0a5..2eb27973f8c03f76fe63c9f0df5d2deb9583f03b 100644

--- a/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html

+++ b/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js

@@ -1,8 +1,13 @@

-<!DOCTYPE html>

-<html>

-<head>

- <script>

-var pref = chrome.experimental.contentSettings.global.referrersEnabled;

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+var pref = chrome.experimental.privacy.websites.thirdPartyCookiesAllowed;

+function $(id) {

+ return document.getElementById(id);

/**

* Returns whether the |levelOfControl| means that the extension can change the

@@ -11,8 +16,8 @@ var pref = chrome.experimental.contentSettings.global.referrersEnabled;

* @param levelOfControl{string}

function settingIsControllable(levelOfControl) {

- return (levelOfControl == "controllable_by_this_extension" ||

- levelOfControl == "controlled_by_this_extension");

+ return (levelOfControl == 'controllable_by_this_extension' ||

+ levelOfControl == 'controlled_by_this_extension');

}

/**

@@ -23,17 +28,17 @@ function settingIsControllable(levelOfControl) {

function updateUI(settings) {

var disableUI = !settingIsControllable(settings.levelOfControl);

- document.getElementById("regularValue").disabled = disableUI;

- document.getElementById("useSeparateIncognitoSettings").disabled = disableUI;

+ document.getElementById('regularValue').disabled = disableUI;

+ document.getElementById('useSeparateIncognitoSettings').disabled = disableUI;

if (settings.hasOwnProperty('incognitoSpecific')) {

var hasIncognitoValue = settings.incognitoSpecific;

- document.getElementById("useSeparateIncognitoSettings").checked =

+ document.getElementById('useSeparateIncognitoSettings').checked =

hasIncognitoValue;

- document.getElementById("incognitoValue").disabled =

+ document.getElementById('incognitoValue').disabled =

disableUI || !hasIncognitoValue;

- document.getElementById("incognitoValue").checked = settings.value;

+ document.getElementById('incognitoValue').checked = settings.value;

} else {

- document.getElementById("regularValue").checked = settings.value;

+ document.getElementById('regularValue').checked = settings.value;

}

@@ -70,12 +75,22 @@ function init() {

chrome.extension.isAllowedIncognitoAccess(function(allowed) {

if (allowed) {

pref.get({'incognito': true}, updateUIFromGet);

- document.getElementById("incognito").style.display = "block";

- document.getElementById("incognito-forbidden").style.display = "none";

+ $('incognito').style.display = 'block';

+ $('incognito-forbidden').style.display = 'none';

}

});

pref.get({}, updateUIFromGet);

pref.onChange.addListener(updateUIFromOnChange);

+ $('regularValue').addEventListener('click', function () {

+ setPrefValue(this.checked, false);

+ });

+ $('useSeparateIncognitoSettings').addEventListener('click', function () {

+ setUseSeparateIncognitoSettings(this.checked);

+ });

+ $('incognitoValue').addEventListener('click', function () {

+ setPrefValue(this.checked, true);

+ });

}

/**

@@ -105,25 +120,8 @@ function setUseSeparateIncognitoSettings(value) {

pref.set({'incognito': true, 'value': settings.value});

});

}

- document.getElementById("incognitoValue").disabled = !value;

+ document.getElementById('incognitoValue').disabled = !value;

}

- </script>

-</head>

-<body onload="init()">

-<div style="width: 300px">

-<input type="checkbox" onclick="setPrefValue(this.checked)" id="regularValue" /> Enable referrers

-<div id="incognito" style="display:none">

-<input type="checkbox" onclick="setUseSeparateIncognitoSettings(this.checked)" id="useSeparateIncognitoSettings" /> Use separate setting for incognito mode:

-<br>

-<input type="checkbox" onclick="setPrefValue(this.checked, true)" id="incognitoValue" disabled="disabled"/> Enable referrers in incognito sessions

-</div>

-<div id="incognito-forbidden">

-Select "Allow in incognito" to access incognito preferences

-</div>

-</body>

-</html>

+// Call `init` to kick things off.

+document.addEventListener('DOMContentLoaded', init);