net/http/http_auth_sspi_win_unittest.cc - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_sspi_win_unittest.cc

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reduce password zapping Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_sspi_win_unittest.cc

diff --git a/net/http/http_auth_sspi_win_unittest.cc b/net/http/http_auth_sspi_win_unittest.cc

index 331dcd6ad562bbc080c9b21bd02136d4260d7ece..4a413e4a0150e012821733772b1e541788858e0f 100644

--- a/net/http/http_auth_sspi_win_unittest.cc

+++ b/net/http/http_auth_sspi_win_unittest.cc

@@ -82,8 +82,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_TwoRounds) {

// Generate an auth token and create another thing.

std::string auth_token;

- EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, NULL,

- L"HTTP/intranet.google.com",

+ EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, L"HTTP/intranet.google.com",

&auth_token));

std::string second_challenge_text = "Negotiate Zm9vYmFy";

@@ -119,8 +118,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_MissingTokenSecondRound) {

auth_sspi.ParseChallenge(&first_challenge));

std::string auth_token;

- EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, NULL,

- L"HTTP/intranet.google.com",

+ EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, L"HTTP/intranet.google.com",

&auth_token));

std::string second_challenge_text = "Negotiate";

HttpAuth::ChallengeTokenizer second_challenge(second_challenge_text.begin(),

@@ -142,8 +140,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_NonBase64EncodedToken) {

auth_sspi.ParseChallenge(&first_challenge));

std::string auth_token;

- EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, NULL,

- L"HTTP/intranet.google.com",

+ EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, L"HTTP/intranet.google.com",

&auth_token));

std::string second_challenge_text = "Negotiate =happyjoy=";

HttpAuth::ChallengeTokenizer second_challenge(second_challenge_text.begin(),

« net/http/http_auth_handler_negotiate.h ('K') | « net/http/http_auth_sspi_win.cc ('k') | net/http/http_cache_transaction.h » ('j') | net/http/http_cache_transaction.h » ('J')