net/http/http_auth_handler_negotiate.h - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_negotiate.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reduce password zapping Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_handler_negotiate.h

diff --git a/net/http/http_auth_handler_negotiate.h b/net/http/http_auth_handler_negotiate.h

index 4b04f7b389a67d2665d77f4d6561db4e26c9af85..9de3c7ff2a141610ba5b59a072bd9da6c8aaa11a 100644

--- a/net/http/http_auth_handler_negotiate.h

+++ b/net/http/http_auth_handler_negotiate.h

@@ -116,8 +116,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerNegotiate : public HttpAuthHandler {

protected:

virtual bool Init(HttpAuth::ChallengeTokenizer* challenge);

- virtual int GenerateAuthTokenImpl(const string16* username,

- const string16* password,

+ virtual int GenerateAuthTokenImpl(const AuthCredentials* credentials,

const HttpRequestInfo* request,

OldCompletionCallback* callback,

std::string* auth_token);

@@ -153,9 +152,8 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerNegotiate : public HttpAuthHandler {

// Things which should be consistent after first call to GenerateAuthToken.

bool already_called_;

- bool has_username_and_password_;

- string16 username_;

- string16 password_;

+ bool has_credentials_;

+ AuthCredentials credentials_;

std::wstring spn_;

// Things which vary each round.

« net/http/http_auth_handler_mock.h ('K') | « net/http/http_auth_handler_mock.cc ('k') | net/http/http_auth_handler_negotiate.cc » ('j') | net/http/http_cache_transaction.h » ('J')