Fix a gcc 4.6 compiler warning.

Fix a gcc 4.6 compiler warning.

../../third_party/icu/public/common/unicode/unistr.h: In member function
‘icu_46::UnicodeString& icu_46::UnicodeString::replace(int32_t, int32_t,
UChar32)’: ../../third_party/icu/public/common/unicode/unistr.h:4026:9: error:
variable ‘isError’ set but not used [-Werror=unused-but-set-variable]
../../third_party/icu/public/common/unicode/unistr.h: In member function
‘icu_46::UnicodeString& icu_46::UnicodeString::append(UChar32)’:
../../third_party/icu/public/common/unicode/unistr.h:4329:9: error: variable
‘isError’ set but not used [-Werror=unused-but-set-variable] cc1plus: all
warnings being treated as errors

BUG=87490

[tony, 2011-10-19 16:59:36]

ping

[jungshik at Google, 2011-10-21 20:50:09]

On 2011/10/19 16:59:36, tony wrote:
> ping

There's another patch that does not use U16_APPEND_UNSAFE (
http://codereview.chromium.org/812001) that I've just landed in the trunk. 

Sorry that I missed this CL. Anyway, I'll roll DEPS for icu.

[tony, 2011-10-21 21:09:17]

On 2011/10/21 20:50:09, Jungshik Shin wrote:
> On 2011/10/19 16:59:36, tony wrote:
> > ping
>
> There's another patch that does not use U16_APPEND_UNSAFE (
> http://codereview.chromium.org/812001) that I've just landed in the
trunk.
>
> Sorry that I missed this CL. Anyway, I'll roll DEPS for icu.

I think you mean http://codereview.chromium.org/8120001/ , but the author
said he preferred this patch (
http://code.google.com/p/chromium/issues/detail?id=97482#c5 ).

If you want, I'll revert the other patch, land this one, and roll DEPS.


>
http://codereview.chromium.**org/8333007/<http://codereview.chromium.org/8333...
>

[jungshik at Google, 2011-10-21 21:31:39]

I like the other patch better :-) I don't think it's a good idea to use
U16_APPEND_UNSAFE for append. 

On 2011/10/21 21:09:17, tony wrote:
> On 2011/10/21 20:50:09, Jungshik Shin wrote:
> > On 2011/10/19 16:59:36, tony wrote:
> > > ping
> >
> > There's another patch that does not use U16_APPEND_UNSAFE (
> > http://codereview.chromium.org/812001) that I've just landed in the
> trunk.
> >
> > Sorry that I missed this CL. Anyway, I'll roll DEPS for icu.
> 
> I think you mean http://codereview.chromium.org/8120001/ , but the author
> said he preferred this patch (
> http://code.google.com/p/chromium/issues/detail?id=97482#c5 ).
> 
> If you want, I'll revert the other patch, land this one, and roll DEPS.
> 
> 
> >
>
http://codereview.chromium.**org/8333007/%3Chttp://codereview.chromium.org/83...>
> >