patches/gcc4.6.patch - Issue 8333007: Fix a gcc 4.6 compiler warning.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: patches/gcc4.6.patch

Issue 8333007: Fix a gcc 4.6 compiler warning. (Closed) Base URL: http://git.chromium.org/chromium/deps/icu46.git@master

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git source/common/unicode/unistr.h source/common/unicode/unistr.h

	2 index 57ea346..46b9d95 100644

	3 --- source/common/unicode/unistr.h

	4 +++ source/common/unicode/unistr.h

	5 @@ -4021,8 +4021,7 @@ UnicodeString::replace(int32_t start,

	6 UChar32 srcChar) {

	7 UChar buffer[U16_MAX_LENGTH];

	8 int32_t count = 0;

	9 - UBool isError = FALSE;

	10 - U16_APPEND(buffer, count, U16_MAX_LENGTH, srcChar, isError);

	11 + U16_APPEND_UNSAFE(buffer, count, srcChar);

	12 return doReplace(start, _length, buffer, 0, count);

	13 }

	14

	15 @@ -4324,8 +4323,7 @@ inline UnicodeString&

	16 UnicodeString::append(UChar32 srcChar) {

	17 UChar buffer[U16_MAX_LENGTH];

	18 int32_t _length = 0;

	19 - UBool isError = FALSE;

	20 - U16_APPEND(buffer, _length, U16_MAX_LENGTH, srcChar, isError);

	21 + U16_APPEND_UNSAFE(buffer, _length, srcChar);

	22 return doReplace(length(), 0, buffer, 0, _length);

	23 }

	24

OLD	NEW

« no previous file with comments | « README.chromium ('k') | public/common/unicode/unistr.h » ('j') | no next file with comments »