Issue 8333006: Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8333006: Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after... (Closed)

Created:
9 years, 2 months ago by Dmitry Titov

Modified:
9 years, 2 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/

Visibility:
Public.

Description

Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after live Iframe transfer. https://bugs.webkit.org/show_bug.cgi?id=70147 Reviewed by David Levin. I only found a way to test this manually, since Chromium TestShell uses static instance of NotificationPresenter instead of per-page one so the issue does not reproduce. Adding manual test that works in full build of Chromium. * manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html: Added. * manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html: Added. * manual-tests/iframe_notifications/iframe-reparenting-close-window.html: Added. * notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::disconnectFrame): * page/DOMWindow.cpp: (WebCore::DOMWindow::resetNotifications): * page/DOMWindow.h: * page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): reset webkitNotifications object. TBR=dimich@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97674

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -10 lines)			Patch
M	Source/WebCore/notifications/NotificationCenter.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/WebCore/page/DOMWindow.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/page/DOMWindow.cpp	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	Source/WebCore/page/Frame.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages