Source/WebCore/page/Frame.cpp - Issue 8333006: Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/page/Frame.cpp

Issue 8333006: Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/page/Frame.cpp

===================================================================

--- Source/WebCore/page/Frame.cpp (revision 97673)

+++ Source/WebCore/page/Frame.cpp (working copy)

@@ -747,8 +747,12 @@

// when the Geolocation's iframe is reparented.

// See https://bugs.webkit.org/show_bug.cgi?id=55577

// and https://bugs.webkit.org/show_bug.cgi?id=52877

- if (m_domWindow)

+ if (m_domWindow) {

m_domWindow->resetGeolocation();

+#if ENABLE(NOTIFICATIONS)

+ m_domWindow->resetNotifications();

+#endif

+ }

#if ENABLE(MEDIA_STREAM)

if (m_mediaStreamFrameController)

« no previous file with comments | « Source/WebCore/page/DOMWindow.cpp ('k') | no next file » | no next file with comments »