[Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error.

chrome/browser/ui/webui/options/personal_options_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/personal_options_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 232 matching lines @@
 void PersonalOptionsHandler::OnStateChanged() {
   string16 status_label;
   string16 link_label;
   ProfileSyncService* service =
       Profile::FromWebUI(web_ui_)->GetProfileSyncService();
   DCHECK(service);
   bool managed = service->IsManaged();
   bool sync_setup_completed = service->HasSyncSetupCompleted();
   bool status_has_error = sync_ui_util::GetStatusLabels(
       service, &status_label, &link_label) == sync_ui_util::SYNC_ERROR;
+  bool has_unrecoverable_error = service->unrecoverable_error_detected();

[James Hawkins, 2011/10/25 17:50:41]

No need for temp var.

[binji, 2011/10/25 18:14:33]

Done.

 
   string16 start_stop_button_label;
   bool is_start_stop_button_visible = false;
   bool is_start_stop_button_enabled = false;
   if (sync_setup_completed) {
     start_stop_button_label =
         l10n_util::GetStringUTF16(IDS_SYNC_STOP_SYNCING_BUTTON_LABEL);
 #if defined(OS_CHROMEOS)
     is_start_stop_button_visible = false;
 #else
@@ skipping 39 matching lines @@
                                   *label);
 
   enabled.reset(Value::CreateBooleanValue(!managed));
   web_ui_->CallJavascriptFunction("PersonalOptions.setSyncActionLinkEnabled",
                                   *enabled);
 
   visible.reset(Value::CreateBooleanValue(status_has_error));
   web_ui_->CallJavascriptFunction("PersonalOptions.setSyncStatusErrorVisible",
                                   *visible);
 
+  enabled.reset(Value::CreateBooleanValue(!has_unrecoverable_error));
+  web_ui_->CallJavascriptFunction(
+      "PersonalOptions.setCustomizeSyncButtonEnabled",
+      *enabled);
+
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAutologin)) {
     visible.reset(Value::CreateBooleanValue(
         service->AreCredentialsAvailable()));
     web_ui_->CallJavascriptFunction("PersonalOptions.setAutoLoginVisible",
                                     *visible);
   }
 
   // Set profile creation text and button if multi-profiles switch is on.
   visible.reset(Value::CreateBooleanValue(multiprofile_));
   web_ui_->CallJavascriptFunction("PersonalOptions.setProfilesSectionVisible",
@@ skipping 86 matching lines @@
     profile_info_list.Append(profile_value);
   }
 
   web_ui_->CallJavascriptFunction("PersonalOptions.setProfilesInfo",
                                   profile_info_list);
 }
 
 void PersonalOptionsHandler::CreateProfile(const ListValue* args) {
   ProfileManager::CreateMultiProfileAsync();
 }