Cocoa: Support keyboard navigation in avatar menu

chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h

Index: chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h
index 28da26fc9deb27776e09249f9f414112f651793e..e418014a1f2e02f8e704fa8f7bed572daa007020 100644
--- a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h
@@ -58,6 +58,9 @@ class Browser;
   // The AvatarMenuModel::item.model_index field.
   size_t modelIndex_;
 
+  // Tracks wheter this item is currently highlighted.
+  BOOL isHighlighted_;
+
   // Instance variables that back the outlets.
   __weak NSImageView* iconView_;
   __weak NSImageView* activeView_;
@@ -69,6 +72,7 @@ class Browser;
   __weak NSButton* editButton_;
 }
 @property(readonly, nonatomic) size_t modelIndex;
+@property(assign, nonatomic) BOOL isHighlighted;

[Robert Sesek, 2011/10/24 19:07:04]

Could you instead make the view key and test for that, rather than maintaing a
separate BOOL? Would it make sense to do that?

[sail, 2011/10/24 19:16:38]

Currently we highlight on mouse over too. I think changing the key view on mouse
over might be a bit weird.

[Robert Sesek, 2011/10/24 19:25:53]

OK.

 @property(assign, nonatomic) IBOutlet NSImageView* iconView;
 @property(assign, nonatomic) IBOutlet NSImageView* activeView;
 @property(assign, nonatomic) IBOutlet NSTextField* nameField;
@@ -102,9 +106,6 @@ class Browser;
 
   // Used to highlight the background on hover.
   ScopedCrTrackingArea trackingArea_;
-
-  // Whether the mouse is inside the bounds of this view.
-  BOOL mouseInside_;
 }
 @property(assign, nonatomic) IBOutlet AvatarMenuItemController* viewController;
 @end