Cocoa: Support keyboard navigation in avatar menu

chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_AVATAR_MENU_BUBBLE_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_AVATAR_MENU_BUBBLE_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/memory/scoped_nsobject.h"
@@ skipping 40 matching lines @@
 
 // This view controller manages the menu item XIB.
 @interface AvatarMenuItemController : NSViewController {
  @private
   // The parent menu controller; owns this.
   __weak AvatarMenuBubbleController* controller_;
 
   // The AvatarMenuModel::item.model_index field.
   size_t modelIndex_;
 
+  // Tracks wheter this item is currently highlighted.
+  BOOL isHighlighted_;
+
   // Instance variables that back the outlets.
   __weak NSImageView* iconView_;
   __weak NSImageView* activeView_;
   __weak NSTextField* nameField_;
   // These two views sit on top of each other, and only one is visible at a
   // time. The editButton_ is visible when the mouse is over the item and the
   // emailField_ is visible otherwise.
   __weak NSTextField* emailField_;
   __weak NSButton* editButton_;
 }
 @property(readonly, nonatomic) size_t modelIndex;
+@property(assign, nonatomic) BOOL isHighlighted;

[Robert Sesek, 2011/10/24 19:07:04]

Could you instead make the view key and test for that, rather than maintaing a
separate BOOL? Would it make sense to do that?

[sail, 2011/10/24 19:16:38]

Currently we highlight on mouse over too. I think changing the key view on mouse
over might be a bit weird.

[Robert Sesek, 2011/10/24 19:25:53]

OK.

 @property(assign, nonatomic) IBOutlet NSImageView* iconView;
 @property(assign, nonatomic) IBOutlet NSImageView* activeView;
 @property(assign, nonatomic) IBOutlet NSTextField* nameField;
 @property(assign, nonatomic) IBOutlet NSTextField* emailField;
 @property(assign, nonatomic) IBOutlet NSButton* editButton;
 
 // Designated initializer.
 - (id)initWithModelIndex:(size_t)modelIndex
           menuController:(AvatarMenuBubbleController*)controller;
 
@@ skipping 13 matching lines @@
 // view controller for changing highlight style of the item subviews. This is
 // an invisible button that underlays most of the menu item and is responsible
 // for performing the switch profile action.
 @interface AvatarMenuItemView : NSView {
  @private
   // The controller that manages this.
   __weak AvatarMenuItemController* viewController_;
 
   // Used to highlight the background on hover.
   ScopedCrTrackingArea trackingArea_;
-
-  // Whether the mouse is inside the bounds of this view.
-  BOOL mouseInside_;
 }
 @property(assign, nonatomic) IBOutlet AvatarMenuItemController* viewController;
 @end
 
 ////////////////////////////////////////////////////////////////////////////////
 
 @interface AccessibilityIgnoredImageCell : NSImageCell
 @end
 
 @interface AccessibilityIgnoredTextFieldCell : NSTextFieldCell
 @end
 
 // Testing API /////////////////////////////////////////////////////////////////
 
 @interface AvatarMenuBubbleController (ExposedForTesting)
 - (id)initWithModel:(AvatarMenuModel*)model
              bridge:(AvatarMenuModelObserver*)bridge
        parentWindow:(NSWindow*)parent
          anchoredAt:(NSPoint)point;
 - (void)performLayout;
 - (NSMutableArray*)items;
 @end
 
 @interface AvatarMenuItemController (ExposedForTesting)
 - (void)willStartAnimation:(NSAnimation*)animation;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_AVATAR_MENU_BUBBLE_CONTROLLER_H_