Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 8329023: OpenBSD patches for base / split from CR #8275005 (Closed)

Created:
9 years, 2 months ago by Robert Nagy
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

OpenBSD patches for base / split from CR #8275005 base/base.gypi: - Add native_library_linux.cc to the openbsd build. - Add '..' to include_dirs so that OS_* definitions are available in symbolize.cc base/debug/debugger_posix.cc: - Add support for figuring out if the process is being debugged on OpenBSD by sharing some code with Mac. base/process_util_unittest.cc: - Disable the OutOfMemoryTest on OpenBSD base/third_party/symbolize/symbolize.cc: - Include the correct elf header on OpenBSD build/linux/system.gyp: - The dl library is linux only, so only use it there. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106078

Patch Set 1 #

Patch Set 2 : The commit bot does not have the power. #

Patch Set 3 : for the buildbot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M base/base.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M base/debug/debugger_posix.cc View 4 chunks +16 lines, -1 line 0 comments Download
M base/process_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
base/third_party/symbolize/symbolize.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Robert Nagy
Please review the following patchset which was split from the huge one.
9 years, 2 months ago (2011-10-18 15:43:32 UTC) #1
Mark Mentovai
LGTM
9 years, 2 months ago (2011-10-18 15:47:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8329023/1
9 years, 2 months ago (2011-10-18 15:47:16 UTC) #3
commit-bot: I haz the power
Can't process patch for file base/third_party/symbolize/symbolize.cc. File's status is None, patchset upload is incomplete.
9 years, 2 months ago (2011-10-18 15:47:18 UTC) #4
Mark Mentovai
Can you try another upload so we can put this through the commit queue?
9 years, 2 months ago (2011-10-18 15:47:41 UTC) #5
Robert Nagy
On 2011/10/18 15:47:41, Mark Mentovai wrote: > Can you try another upload so we can ...
9 years, 2 months ago (2011-10-18 15:56:22 UTC) #6
Mark Mentovai
I don’t know what’s going on with symbolize.cc, it’s not showing up with an “M” ...
9 years, 2 months ago (2011-10-18 16:00:51 UTC) #7
willchan no longer on Chromium
I think that generally means the upload is incomplete =/ On Tue, Oct 18, 2011 ...
9 years, 2 months ago (2011-10-18 16:04:26 UTC) #8
Robert Nagy
On 2011/10/18 16:04:26, willchan wrote: > I think that generally means the upload is incomplete ...
9 years, 2 months ago (2011-10-18 16:06:22 UTC) #9
Mark Mentovai
OK, we’ll do it manually, I just sent it to the tryserver.
9 years, 2 months ago (2011-10-18 16:08:30 UTC) #10
Mark Mentovai
Committed r106078.
9 years, 2 months ago (2011-10-18 17:41:29 UTC) #11
Robert Nagy
9 years, 2 months ago (2011-10-18 17:44:19 UTC) #12
On 2011/10/18 17:41:29, Mark Mentovai wrote:
> Committed r106078.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698