Issue 8318013: Revert 105803 - Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIA...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8318013: Revert 105803 - Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIA... (Closed)

Created:
9 years, 2 months ago by robertshield

Modified:
9 years, 2 months ago

Reviewers:
robertshield

CC:
chromium-reviews, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 105803 - Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8150002 TBR=robertshield@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105823

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -34 lines)			Patch
M	chrome_frame/bho.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	13 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome_frame/chrome_frame_launcher.gyp	View	3 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_protocol.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome_frame/delete_chrome_history.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome_frame/html_private_window_impl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/html_window_impl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome_frame/test/chrome_tab_mocks.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome_frame/test/ie_event_sink.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome_frame/test/test_with_web_server.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)