Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a global...

Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide.BUG=97185
TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/

[grt (UTC plus 2), 2011-10-06 19:55:32]

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp
File chrome_frame/chrome_frame.gyp (right):

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:627: # To allow including "version.h"
please add something like: TODO(grt): remove this as per http://crbug.com/99368

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:746: '<(INTERMEDIATE_DIR)/../chrome_frame',
this is wrong; remove it.  if anything breaks, put the stuff that is needed here
into SHARED_INTERMEDIATE_DIR/chrome_frame so it can be safely shared.

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:870: '<(INTERMEDIATE_DIR)/../npchrome_frame',
remove this, too; see previous comment

[robertshield, 2011-10-14 03:20:03]

Cleaned up the <(INTERMEDIATE_DIR)/../ stuff as well, PTAL

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp
File chrome_frame/chrome_frame.gyp (right):

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:627: # To allow including "version.h"
On 2011/10/06 19:55:32, grt wrote:
> please add something like: TODO(grt): remove this as per
http://crbug.com/99368

Done.

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:746: '<(INTERMEDIATE_DIR)/../chrome_frame',
On 2011/10/06 19:55:32, grt wrote:
> this is wrong; remove it.  if anything breaks, put the stuff that is needed
here
> into SHARED_INTERMEDIATE_DIR/chrome_frame so it can be safely shared.

Done.

http://codereview.chromium.org/8150002/diff/1/chrome_frame/chrome_frame.gyp#n...
chrome_frame/chrome_frame.gyp:870: '<(INTERMEDIATE_DIR)/../npchrome_frame',
On 2011/10/06 19:55:32, grt wrote:
> remove this, too; see previous comment

Done and replaced with path to shared intermediate dir.

[grt (UTC plus 2), 2011-10-14 14:35:00]

LGTM once the years are fixed (bet you thought I would forget them, huh)?

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/chrome_protocol.h
File chrome_frame/chrome_protocol.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/chrome_protocol...
chrome_frame/chrome_protocol.h:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/delete_chrome_h...
File chrome_frame/delete_chrome_history.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/delete_chrome_h...
chrome_frame/delete_chrome_history.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_private_wi...
File chrome_frame/html_private_window_impl.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_private_wi...
chrome_frame/html_private_window_impl.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_window_impl.h
File chrome_frame/html_window_impl.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_window_imp...
chrome_frame/html_window_impl.h:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/test/chrome_tab...
File chrome_frame/test/chrome_tab_mocks.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/test/chrome_tab...
chrome_frame/test/chrome_tab_mocks.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2011

[robertshield, 2011-10-17 13:38:13]

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/chrome_protocol.h
File chrome_frame/chrome_protocol.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/chrome_protocol...
chrome_frame/chrome_protocol.h:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
On 2011/10/14 14:35:00, grt wrote:
> 2011

Done.

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/delete_chrome_h...
File chrome_frame/delete_chrome_history.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/delete_chrome_h...
chrome_frame/delete_chrome_history.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/10/14 14:35:00, grt wrote:
> 2011

Done.

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_private_wi...
File chrome_frame/html_private_window_impl.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_private_wi...
chrome_frame/html_private_window_impl.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
On 2011/10/14 14:35:00, grt wrote:
> 2011

Done.

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_window_impl.h
File chrome_frame/html_window_impl.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/html_window_imp...
chrome_frame/html_window_impl.h:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
On 2011/10/14 14:35:00, grt wrote:
> 2011

Done.

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/test/chrome_tab...
File chrome_frame/test/chrome_tab_mocks.h (right):

http://codereview.chromium.org/8150002/diff/9001/chrome_frame/test/chrome_tab...
chrome_frame/test/chrome_tab_mocks.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/10/14 14:35:00, grt wrote:
> 2011

Done.

[commit-bot: I haz the power, 2011-10-17 13:38:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/8150002/18001

[commit-bot: I haz the power, 2011-10-17 14:56:28]

Change committed as 105803