Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: webkit/plugins/ppapi/resource_tracker.cc

Issue 8316008: Add a new globals object for PPAPI tracking information. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/resource_tracker.cc
diff --git a/webkit/plugins/ppapi/resource_tracker.cc b/webkit/plugins/ppapi/resource_tracker.cc
index 6b0de7d7733a8547cd0b3781a0bc3e414198e49c..074372370dfe4f7ea5a0101cff71f10ae6f05edb 100644
--- a/webkit/plugins/ppapi/resource_tracker.cc
+++ b/webkit/plugins/ppapi/resource_tracker.cc
@@ -15,6 +15,7 @@
#include "ppapi/shared_impl/id_assignment.h"
#include "ppapi/shared_impl/tracker_base.h"
#include "webkit/plugins/ppapi/callbacks.h"
+#include "webkit/plugins/ppapi/host_globals.h"
#include "webkit/plugins/ppapi/npobject_var.h"
#include "webkit/plugins/ppapi/plugin_module.h"
#include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
@@ -36,7 +37,7 @@ namespace ppapi {
namespace {
::ppapi::TrackerBase* GetTrackerBase() {
- return ResourceTracker::Get();
+ return HostGlobals::Get()->host_resource_tracker();
}
} // namespace
@@ -61,10 +62,6 @@ struct ResourceTracker::InstanceData {
function_proxies[::ppapi::proxy::INTERFACE_ID_COUNT];
};
-// static
-ResourceTracker* ResourceTracker::global_tracker_ = NULL;
-ResourceTracker* ResourceTracker::singleton_override_ = NULL;
-
ResourceTracker::ResourceTracker() {
// Wire up the new shared resource tracker base to use our implementation.
::ppapi::TrackerBase::Init(&GetTrackerBase);
@@ -73,15 +70,6 @@ ResourceTracker::ResourceTracker() {
ResourceTracker::~ResourceTracker() {
}
-// static
-ResourceTracker* ResourceTracker::Get() {
- if (singleton_override_)
- return singleton_override_;
- if (!global_tracker_)
- global_tracker_ = new ResourceTracker;
- return global_tracker_;
-}
-
void ResourceTracker::CleanupInstanceData(PP_Instance instance,
bool delete_instance) {
DLOG_IF(ERROR, !CheckIdType(instance, ::ppapi::PP_ID_TYPE_INSTANCE))
@@ -154,14 +142,6 @@ void ResourceTracker::CleanupInstanceData(PP_Instance instance,
return proxy.get();
}
-::ppapi::VarTracker* ResourceTracker::GetVarTracker() {
- return &var_tracker_;
-}
-
-::ppapi::ResourceTracker* ResourceTracker::GetResourceTracker() {
- return this;
-}
-
PP_Module ResourceTracker::GetModuleForInstance(PP_Instance instance) {
PluginInstance* inst = GetInstance(instance);
if (!inst)
@@ -309,17 +289,5 @@ PluginModule* ResourceTracker::GetModule(PP_Module module) {
return found->second;
}
-// static
-void ResourceTracker::SetSingletonOverride(ResourceTracker* tracker) {
- DCHECK(!singleton_override_);
- singleton_override_ = tracker;
-}
-
-// static
-void ResourceTracker::ClearSingletonOverride() {
- DCHECK(singleton_override_);
- singleton_override_ = NULL;
-}
-
} // namespace ppapi
} // namespace webkit
« ppapi/proxy/ppb_video_capture_proxy.cc ('K') | « webkit/plugins/ppapi/resource_tracker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698