Fix minor WebUI dialog issues, mostly with bookmark management

Fix minor WebUI dialog issues, mostly with bookmark management.

Make the bookmark manager consistently reset the hash when starting to edit (so that when editing is complete, a new edit operation can still be invoked on the same element).

Disable the console diagnostics on navigateTo (to be consistent with the other disabled diagnostics in this file).

Make WebUI bookmark editing work on Mac (Mac was invoking the native UI directly instead of going through the BookmarkEditor class which decides which UI to show).

Make 'Add page' pre-populate the bookmark entry with the title/url of the current page (as for the non-webui behavior).  Note that based on UX feedback, we probably don't want to use the bookmark manager in this case at all, so we'll probably add a new dialog for this.  But I already had this ready and it's a step closer (removes a= from bookmark manager, etc.) so I'm still committing it for now. 

Make the certificate viewer non-modal to match the native version.

BUG=99205
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107039

[Rick Byers, 2011-10-24 18:42:09]

Hey Rob,
Can you review these tweaks for me.

Mazda: FYI due to the relationship with your bookmarks work.

Thanks!
   Rick

[flackr, 2011-10-24 19:16:01]

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/resources/boo...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/resources/boo...
chrome/browser/resources/bookmark_manager/js/main.js:133: * Update the locaiton
hash to reflect the current state of the application.
s/Update/Updates (as per style guide statement that function comments are
descriptive rather than imperative)
s/locaiton/location

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller.mm:1631: if (node) {
Remove {}

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller.mm:1632:
BookmarkEditor::Show([self window], browser_->profile(),
Should only be indented 6 spaces.

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
File chrome/browser/ui/webui/certificate_viewer.cc (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer.cc:72: return false;
This might allow a crash when exporting a certificate from a certificate viewer
dialog whose parent window has been closed. This is because currently
CertificateViewerDialogHandler::ExportCertificate passes the parent of the
certificate viewer dialog through to ShowCertExportDialog. You can assign this
to me to fix if you'd like.

[Rick Byers, 2011-10-24 20:02:42]

Thanks Rob.

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/resources/boo...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/resources/boo...
chrome/browser/resources/bookmark_manager/js/main.js:133: * Update the locaiton
hash to reflect the current state of the application.
On 2011/10/24 19:16:01, flackr wrote:
> s/Update/Updates (as per style guide statement that function comments are
> descriptive rather than imperative)

Done, thanks for the style pointer!

> s/locaiton/location

Done

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller.mm:1631: if (node) {
On 2011/10/24 19:16:01, flackr wrote:
> Remove {}

Done.

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller.mm:1632:
BookmarkEditor::Show([self window], browser_->profile(),
On 2011/10/24 19:16:01, flackr wrote:
> Should only be indented 6 spaces.

Done.

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
File chrome/browser/ui/webui/certificate_viewer.cc (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer.cc:72: return false;
On 2011/10/24 19:16:01, flackr wrote:
> This might allow a crash when exporting a certificate from a certificate
viewer
> dialog whose parent window has been closed. This is because currently
> CertificateViewerDialogHandler::ExportCertificate passes the parent of the
> certificate viewer dialog through to ShowCertExportDialog. You can assign this
> to me to fix if you'd like.

Ah, good catch.  Do you think the fix is easy?  I'd rather not block UI review
on this, so I've filed http://code.google.com/p/chromium/issues/detail?id=101402
to you.  However, if you think a better option is to just make the certificate
viewer modal (i.e. if there isn't an easy fix), then we could go with that to UI
review instead.

[flackr, 2011-10-24 20:39:33]

LGTM

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
File chrome/browser/ui/webui/certificate_viewer.cc (right):

http://codereview.chromium.org/8314017/diff/2002/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer.cc:72: return false;
On 2011/10/24 20:02:42, Rick Byers wrote:
> On 2011/10/24 19:16:01, flackr wrote:
> > This might allow a crash when exporting a certificate from a certificate
> viewer
> > dialog whose parent window has been closed. This is because currently
> > CertificateViewerDialogHandler::ExportCertificate passes the parent of the
> > certificate viewer dialog through to ShowCertExportDialog. You can assign
this
> > to me to fix if you'd like.
> 
> Ah, good catch.  Do you think the fix is easy?  I'd rather not block UI review
> on this, so I've filed
http://code.google.com/p/chromium/issues/detail?id=101402
> to you.  However, if you think a better option is to just make the certificate
> viewer modal (i.e. if there isn't an easy fix), then we could go with that to
UI
> review instead.  

I think the fix will be easy. There has to be some window that we can select and
parent the dialog on even if not the certificate viewer dialog window.

[commit-bot: I haz the power, 2011-10-24 23:26:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/8314017/7001

[commit-bot: I haz the power, 2011-10-25 02:05:31]

Change committed as 107039