Fix minor WebUI dialog issues, mostly with bookmark management

chrome/browser/ui/webui/certificate_viewer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/i18n/time_formatting.h"
 #include "base/utf_string_conversions.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
@@ skipping 51 matching lines @@
   x509_certificate_model::GetCertChainFromCert(cert_->os_cert_handle(),
       &cert_chain);
   title_ = l10n_util::GetStringFUTF16(IDS_CERT_INFO_DIALOG_TITLE,
       UTF8ToUTF16(x509_certificate_model::GetTitle(cert_chain.front())));
 }
 
 CertificateViewerDialog::~CertificateViewerDialog() {
 }
 
 bool CertificateViewerDialog::IsDialogModal() const {
-  return true;
+  return false;

[flackr, 2011/10/24 19:16:01]

This might allow a crash when exporting a certificate from a certificate viewer
dialog whose parent window has been closed. This is because currently
CertificateViewerDialogHandler::ExportCertificate passes the parent of the
certificate viewer dialog through to ShowCertExportDialog. You can assign this
to me to fix if you'd like.

[Rick Byers, 2011/10/24 20:02:42]

Ah, good catch.  Do you think the fix is easy?  I'd rather not block UI review
on this, so I've filed http://code.google.com/p/chromium/issues/detail?id=101402
to you.  However, if you think a better option is to just make the certificate
viewer modal (i.e. if there isn't an easy fix), then we could go with that to UI
review instead.  

[flackr, 2011/10/24 20:39:33]

I think the fix will be easy. There has to be some window that we can select and
parent the dialog on even if not the certificate viewer dialog window.

 }
 
 string16 CertificateViewerDialog::GetDialogTitle() const {
   return title_;
 }
 
 GURL CertificateViewerDialog::GetDialogContentURL() const {
   return GURL(chrome::kChromeUICertificateViewerURL);
 }
 
@@ skipping 313 matching lines @@
   cert_sub_fields->Append(node_details = new DictionaryValue());
   node_details->SetString("label",
       l10n_util::GetStringUTF8(IDS_CERT_INFO_SHA1_FINGERPRINT_LABEL));
   node_details->SetString("payload.val",
       x509_certificate_model::HashCertSHA1(cert));
 
   // Send certificate information to javascript.
   web_ui_->CallJavascriptFunction("cert_viewer.getCertificateFields",
       root_list);
 }