Fix a potential CFRelease(NULL).

Fix a potential CFRelease(NULL).

It would happen if CreateClientCertificateChain() returns NULL.
Found by the clang static analyzer. Probably doesn't happen in
practice.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107041

[Ryan Sleevi, 2011-10-16 18:31:01]

LGTM, but you won't be able to CQ it - not a net/ OWNERS.

[Nico, 2011-10-16 18:57:32]

eroman for OWNERS

[eroman, 2011-10-24 23:52:25]

lgtm. oops didnt see this in my queue!

[commit-bot: I haz the power, 2011-10-24 23:59:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8308009/1

[commit-bot: I haz the power, 2011-10-24 23:59:25]

Can't apply patch for file net/socket/ssl_client_socket_nss.cc.
While running patch -p1 --forward --force;
patching file net/socket/ssl_client_socket_nss.cc
Hunk #1 FAILED at 2385.
1 out of 1 hunk FAILED -- saving rejects to file
net/socket/ssl_client_socket_nss.cc.rej

[commit-bot: I haz the power, 2011-10-25 00:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8308009/6001

[Nico, 2011-10-25 00:12:45]

Thanks for the review. After rebasing, it looks a bit different.

[Ryan Sleevi, 2011-10-25 00:14:16]

http://codereview.chromium.org/8308009/diff/6001/net/socket/ssl_client_socket...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/8308009/diff/6001/net/socket/ssl_client_socket...
net/socket/ssl_client_socket_nss.cc:2388: CFArrayGetCount(chain);
nico: Unchecked commit box. Now, |cert_count| is no longer updated.

I'm assuming this should be cert_count = CFArrayGetCount(chain); ?

[Nico, 2011-10-25 00:16:02]

yes, done, thanks.

i wonder if clang would've caught this…maybe CFGetArrayCount() is marked as
pure?

[commit-bot: I haz the power, 2011-10-25 00:16:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8308009/9001

[commit-bot: I haz the power, 2011-10-25 02:05:49]

Change committed as 107041