Issue 8303004: [Sync] Only step to done in wizard if encryption is complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8303004: [Sync] Only step to done in wizard if encryption is complete. (Closed)

Created:
9 years, 2 months ago by Nicolas Zea

Modified:
9 years, 2 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Only step to done in wizard if encryption is complete. This caused attempts to encrypt everything on first time sync to fail due to stepping to done triggering the window to close which gets handled as if the user cancelled setup (clearing encryption_pending_). BUG=90063 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105635

Patch Set 1 #

Patch Set 2 : Add case to sync setup flow #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/sync/sync_setup_flow.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

Alright, added a check in the sync setup flow, and verified all the cases where ...

9 years, 2 months ago (2011-10-15 01:12:22 UTC) #2

Andrew T Wilson (Slow)

9 years, 2 months ago (2011-10-15 01:56:09 UTC) #3

On 2011/10/15 01:12:22, nzea wrote:
> Alright, added a check in the sync setup flow, and verified all the cases
where
> we can step to done are covered.

LGTM

Expand Messages | Collapse Messages