Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 8303004: [Sync] Only step to done in wizard if encryption is complete. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add case to sync setup flow Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/sync_setup_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index 9cbb4df057af99e1ca562bad4cce61a0084c61b5..ac8a84ff472080c02374d16eefcd2ff3072f328c 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -817,10 +817,11 @@ void ProfileSyncService::ResolvePassphraseRequired() {
sync_api::CONFIGURE_REASON_RECONFIGURATION);
}
- // No encryption is pending, our passphrase has been accepted, so tell the
+ // If No encryption is pending and our passphrase has been accepted, tell the
// wizard we're done (no need to hang around waiting for the sync to
- // complete).
- if (WizardIsVisible())
+ // complete). If encryption is pending, its successful completion will trigger
+ // the done step.
+ if (WizardIsVisible() && !encryption_pending())
wizard_.Step(SyncSetupWizard::DONE);
NotifyObservers();
« no previous file with comments | « no previous file | chrome/browser/sync/sync_setup_flow.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698